summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorKarthikeyan Periyasamy <periyasa@codeaurora.org>2019-07-24 14:46:10 +0530
committerJohannes Berg <johannes.berg@intel.com>2019-07-31 11:00:52 +0200
commit52dba8d7d5aba65f818bd27603ae10ebc006ab3b (patch)
tree7643050ea2c2a837e2043662ed802cdd42bdd0dc /net
parent50508d941c180a105fdba802d5af1abf3d93a625 (diff)
downloadlinux-52dba8d7d5aba65f818bd27603ae10ebc006ab3b.tar.gz
linux-52dba8d7d5aba65f818bd27603ae10ebc006ab3b.tar.bz2
linux-52dba8d7d5aba65f818bd27603ae10ebc006ab3b.zip
mac80211: reject zero MAC address in add station
This came up in fuzz testing, and really we don't consider all-zeroes to be a valid MAC address in most places, so also reject it here to avoid confusion later on. Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org> Link: https://lore.kernel.org/r/1563959770-21570-1-git-send-email-periyasa@codeaurora.org [rewrite commit message] Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net')
-rw-r--r--net/mac80211/cfg.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 4d458067d80d..10b99b263c4f 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1543,7 +1543,7 @@ static int ieee80211_add_station(struct wiphy *wiphy, struct net_device *dev,
if (ether_addr_equal(mac, sdata->vif.addr))
return -EINVAL;
- if (is_multicast_ether_addr(mac))
+ if (!is_valid_ether_addr(mac))
return -EINVAL;
sta = sta_info_alloc(sdata, mac, GFP_KERNEL);