summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2019-05-16 08:09:57 -0700
committerDavid S. Miller <davem@davemloft.net>2019-05-16 14:25:58 -0700
commitd7c04b05c9ca14c55309eb139430283a45c4c25f (patch)
tree430f3db330f5830a4ccbfb0747d605b2c9ca43fa /net
parente3a9f61b7ec3fd49227c3558d5ea897b75212871 (diff)
downloadlinux-d7c04b05c9ca14c55309eb139430283a45c4c25f.tar.gz
linux-d7c04b05c9ca14c55309eb139430283a45c4c25f.tar.bz2
linux-d7c04b05c9ca14c55309eb139430283a45c4c25f.zip
net: avoid weird emergency message
When host is under high stress, it is very possible thread running netdev_wait_allrefs() returns from msleep(250) 10 seconds late. This leads to these messages in the syslog : [...] unregister_netdevice: waiting for syz_tun to become free. Usage count = 0 If the device refcount is zero, the wait is over. Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/dev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 108ac8137b9b..b6b8505cfb3e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -8927,7 +8927,7 @@ static void netdev_wait_allrefs(struct net_device *dev)
refcnt = netdev_refcnt_read(dev);
- if (time_after(jiffies, warning_time + 10 * HZ)) {
+ if (refcnt && time_after(jiffies, warning_time + 10 * HZ)) {
pr_emerg("unregister_netdevice: waiting for %s to become free. Usage count = %d\n",
dev->name, refcnt);
warning_time = jiffies;