summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2019-10-09 14:51:20 -0700
committerJakub Kicinski <jakub.kicinski@netronome.com>2019-10-09 21:34:31 -0700
commit60b173ca3d1cd1782bd0096dc17298ec242f6fb1 (patch)
tree63dcac48023790e1acfb33271d47d5d4132ca55c /net
parent503978aca46124cd714703e180b9c8292ba50ba7 (diff)
downloadlinux-60b173ca3d1cd1782bd0096dc17298ec242f6fb1.tar.gz
linux-60b173ca3d1cd1782bd0096dc17298ec242f6fb1.tar.bz2
linux-60b173ca3d1cd1782bd0096dc17298ec242f6fb1.zip
net: add {READ|WRITE}_ONCE() annotations on ->rskq_accept_head
reqsk_queue_empty() is called from inet_csk_listen_poll() while other cpus might write ->rskq_accept_head value. Use {READ|WRITE}_ONCE() to avoid compiler tricks and potential KCSAN splats. Fixes: fff1f3001cc5 ("tcp: add a spinlock to protect struct request_sock_queue") Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/inet_connection_sock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index a9183543ca30..dbcf34ec8dd2 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -934,7 +934,7 @@ struct sock *inet_csk_reqsk_queue_add(struct sock *sk,
req->sk = child;
req->dl_next = NULL;
if (queue->rskq_accept_head == NULL)
- queue->rskq_accept_head = req;
+ WRITE_ONCE(queue->rskq_accept_head, req);
else
queue->rskq_accept_tail->dl_next = req;
queue->rskq_accept_tail = req;