diff options
| author | Sven Eckelmann <sven.eckelmann@open-mesh.com> | 2016-09-29 17:22:58 +0200 |
|---|---|---|
| committer | Simon Wunderlich <sw@simonwunderlich.de> | 2016-10-17 16:10:53 +0200 |
| commit | 9ca488dd53088d4fcc97258aeeccf21f63b7da1e (patch) | |
| tree | 3bb060702d0fa1d2067c224cf3319d0a9b276607 /net | |
| parent | 29fbff8698fc0ac1a1d74584b258e0bf18b469f9 (diff) | |
| download | linux-9ca488dd53088d4fcc97258aeeccf21f63b7da1e.tar.gz linux-9ca488dd53088d4fcc97258aeeccf21f63b7da1e.tar.bz2 linux-9ca488dd53088d4fcc97258aeeccf21f63b7da1e.zip | |
batman-adv: Modify neigh_list only with rcu-list functions
The batadv_hard_iface::neigh_list is accessed via rcu based primitives.
Thus all operations done on it have to fulfill the requirements by RCU. So
using non-RCU mechanisms like hlist_add_head is not allowed because it
misses the barriers required to protect concurrent readers when accessing
the data behind the pointer.
Fixes: cef63419f7db ("batman-adv: add list of unique single hop neighbors per hard-interface")
Signed-off-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/batman-adv/originator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 5f3bfc41aeb1..7c8d16086f0f 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -544,7 +544,7 @@ batadv_hardif_neigh_create(struct batadv_hard_iface *hard_iface, if (bat_priv->algo_ops->neigh.hardif_init) bat_priv->algo_ops->neigh.hardif_init(hardif_neigh); - hlist_add_head(&hardif_neigh->list, &hard_iface->neigh_list); + hlist_add_head_rcu(&hardif_neigh->list, &hard_iface->neigh_list); out: spin_unlock_bh(&hard_iface->neigh_list_lock); |