diff options
| author | Sven Eckelmann <sven@narfation.org> | 2015-03-01 16:56:26 +0100 |
|---|---|---|
| committer | Antonio Quartulli <antonio@meshcoding.com> | 2015-06-03 15:57:23 +0200 |
| commit | a0c77227ffd0ad371cfde84458f440bcde5ab048 (patch) | |
| tree | 78acbd82574a1e8aea249962b2ff39696b9e8561 /net | |
| parent | 21102626da60a6fcb0458e4040ee4739f04652e8 (diff) | |
| download | linux-a0c77227ffd0ad371cfde84458f440bcde5ab048.tar.gz linux-a0c77227ffd0ad371cfde84458f440bcde5ab048.tar.bz2 linux-a0c77227ffd0ad371cfde84458f440bcde5ab048.zip | |
batman-adv: Remove unnecessary check for orig_ifinfo not NULL
orig_ifinfo is dereferenced multiple times in batadv_iv_ogm_update_seqnos
before the check for NULL is done. The function also exists at the
beginning when orig_ifinfo would have been NULL. This makes the check at
the end unnecessary and only confuses the reader/code analyzers.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Diffstat (limited to 'net')
| -rw-r--r-- | net/batman-adv/bat_iv_ogm.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index 9f83137a6514..4e93d2d3958b 100644 --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -1357,8 +1357,7 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr, out: spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock); batadv_orig_node_free_ref(orig_node); - if (orig_ifinfo) - batadv_orig_ifinfo_free_ref(orig_ifinfo); + batadv_orig_ifinfo_free_ref(orig_ifinfo); return ret; } |