diff options
author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2021-08-10 18:31:01 -0500 |
---|---|---|
committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2022-01-06 14:00:20 -0500 |
commit | c72a826829ccfb38019187a3a5ba6d3584b7b7dc (patch) | |
tree | 11a21fd0e943c5dbdf2ef791e14b2c4a443485ab /net | |
parent | 4b0c359b813bbf115f5e2219ea8c0e4fad92400b (diff) | |
download | linux-c72a826829ccfb38019187a3a5ba6d3584b7b7dc.tar.gz linux-c72a826829ccfb38019187a3a5ba6d3584b7b7dc.tar.bz2 linux-c72a826829ccfb38019187a3a5ba6d3584b7b7dc.zip |
nfs41: pnfs: filelayout: Replace one-element array with flexible-array member
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].
Refactor the code a bit according to the use of a flexible-array member
in struct nfs4_file_layout_dsaddr instead of a one-element array, and
use the struct_size() helper.
This helps with the ongoing efforts to globally enable -Warray-bounds
and get us closer to being able to tighten the FORTIFY_SOURCE routines
on memcpy().
This issue was found with the help of Coccinelle and audited and fixed,
manually.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/109
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions