summaryrefslogtreecommitdiffstats
path: root/samples/kdb
diff options
context:
space:
mode:
authorMatt Fleming <matt.fleming@intel.com>2014-04-10 14:11:45 +0100
committerMatt Fleming <matt.fleming@intel.com>2014-04-10 21:20:03 +0100
commit47514c996fac5e6f13ef3a4c5e23f1c5cffabb7b (patch)
treecd8abfa789364bf25eeb2edc415a16ee08a9a25d /samples/kdb
parent7e8213c1f3acc064aef37813a39f13cbfe7c3ce7 (diff)
downloadlinux-47514c996fac5e6f13ef3a4c5e23f1c5cffabb7b.tar.gz
linux-47514c996fac5e6f13ef3a4c5e23f1c5cffabb7b.tar.bz2
linux-47514c996fac5e6f13ef3a4c5e23f1c5cffabb7b.zip
efi: Pass correct file handle to efi_file_{read,close}
We're currently passing the file handle for the root file system to efi_file_read() and efi_file_close(), instead of the file handle for the file we wish to read/close. While this has worked up until now, it seems that it has only been by pure luck. Olivier explains, "The issue is the UEFI Fat driver might return the same function for 'fh->read()' and 'h->read()'. While in our case it does not work with a different implementation of EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. In our case, we return a different pointer when reading a directory and reading a file." Fixing this actually clears up the two functions because we can drop one of the arguments, and instead only pass a file 'handle' argument. Reported-by: Olivier Martin <olivier.martin@arm.com> Reviewed-by: Olivier Martin <olivier.martin@arm.com> Reviewed-by: Mark Rutland <mark.rutland@arm.com> Cc: Leif Lindholm <leif.lindholm@linaro.org> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'samples/kdb')
0 files changed, 0 insertions, 0 deletions