diff options
| author | Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com> | 2024-03-26 17:56:25 +0800 |
|---|---|---|
| committer | Mickaël Salaün <mic@digikod.net> | 2024-05-13 06:58:26 +0200 |
| commit | 42212936d9d811c7cf6efc4804747a6c417aafd4 (patch) | |
| tree | 65d157f3d26532c204d20d05c8415108bee560ac /samples | |
| parent | a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6 (diff) | |
| download | linux-42212936d9d811c7cf6efc4804747a6c417aafd4.tar.gz linux-42212936d9d811c7cf6efc4804747a6c417aafd4.tar.bz2 linux-42212936d9d811c7cf6efc4804747a6c417aafd4.zip | |
samples/landlock: Fix incorrect free in populate_ruleset_net
Pointer env_port_name changes after strsep(). Memory allocated via
strdup() will not be freed if landlock_add_rule() returns non-zero value.
Fixes: 5e990dcef12e ("samples/landlock: Support TCP restrictions")
Signed-off-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Reviewed-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Link: https://lore.kernel.org/r/20240326095625.3576164-1-ivanov.mikhail1@huawei-partners.com
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Diffstat (limited to 'samples')
| -rw-r--r-- | samples/landlock/sandboxer.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c index 32e930c853bb..8b8ecd65c28c 100644 --- a/samples/landlock/sandboxer.c +++ b/samples/landlock/sandboxer.c @@ -153,7 +153,7 @@ static int populate_ruleset_net(const char *const env_var, const int ruleset_fd, const __u64 allowed_access) { int ret = 1; - char *env_port_name, *strport; + char *env_port_name, *env_port_name_next, *strport; struct landlock_net_port_attr net_port = { .allowed_access = allowed_access, .port = 0, @@ -165,7 +165,8 @@ static int populate_ruleset_net(const char *const env_var, const int ruleset_fd, env_port_name = strdup(env_port_name); unsetenv(env_var); - while ((strport = strsep(&env_port_name, ENV_DELIMITER))) { + env_port_name_next = env_port_name; + while ((strport = strsep(&env_port_name_next, ENV_DELIMITER))) { net_port.port = atoi(strport); if (landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_PORT, &net_port, 0)) { |