summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorFabio Estevam <fabio.estevam@freescale.com>2014-12-10 15:51:40 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2014-12-10 17:41:11 -0800
commit15160f90b8640b7d83ec8cdac64c65403355faa6 (patch)
tree43eec7a6f315dffd884646812caf55713430b1a1 /scripts
parent04941aa774320eb0118339c8cd11d7f1321e74d3 (diff)
downloadlinux-15160f90b8640b7d83ec8cdac64c65403355faa6.tar.gz
linux-15160f90b8640b7d83ec8cdac64c65403355faa6.tar.bz2
linux-15160f90b8640b7d83ec8cdac64c65403355faa6.zip
checkpatch: improve warning message for "needless if" case
Add an 'and' to the sentence so that it looks better: WARNING: debugfs_remove(NULL) is safe and this check is probably not required Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Cc: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/checkpatch.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d94f5d879fb1..10ad5ab571dc 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4446,7 +4446,7 @@ sub process {
my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
WARN('NEEDLESS_IF',
- "$1(NULL) is safe this check is probably not required\n" . $hereprev);
+ "$1(NULL) is safe and this check is probably not required\n" . $hereprev);
}
}