diff options
| author | Xiu Jianfeng <xiujianfeng@huawei.com> | 2022-06-14 17:00:01 +0800 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2022-07-09 15:13:59 -0700 |
| commit | 417ea9fe972d2654a268ad66e89c8fcae67017c3 (patch) | |
| tree | 25481a3e42f8903bd8154c12e189f9ba29cbce47 /security/apparmor/apparmorfs.c | |
| parent | 11c3627ec6b56c1525013f336f41b79a983b4d46 (diff) | |
| download | linux-417ea9fe972d2654a268ad66e89c8fcae67017c3.tar.gz linux-417ea9fe972d2654a268ad66e89c8fcae67017c3.tar.bz2 linux-417ea9fe972d2654a268ad66e89c8fcae67017c3.zip | |
apparmor: Fix memleak in aa_simple_write_to_buffer()
When copy_from_user failed, the memory is freed by kvfree. however the
management struct and data blob are allocated independently, so only
kvfree(data) cause a memleak issue here. Use aa_put_loaddata(data) to
fix this issue.
Fixes: a6a52579e52b5 ("apparmor: split load data into management struct and data blob")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security/apparmor/apparmorfs.c')
| -rw-r--r-- | security/apparmor/apparmorfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index 8b9c92f3ff95..0275a350dc23 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -403,7 +403,7 @@ static struct aa_loaddata *aa_simple_write_to_buffer(const char __user *userbuf, data->size = copy_size; if (copy_from_user(data->data, userbuf, copy_size)) { - kvfree(data); + aa_put_loaddata(data); return ERR_PTR(-EFAULT); } |