diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-09-20 20:16:27 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-24 14:41:04 -0700 |
commit | 59104f062435c7816e39ee5ed504a69cb8037f10 (patch) | |
tree | cc77c6202d01b9c152634b836fa06e77b27d14fc /security/selinux | |
parent | a02cec2155fbea457eca8881870fd2de1a4c4c76 (diff) | |
download | linux-59104f062435c7816e39ee5ed504a69cb8037f10.tar.gz linux-59104f062435c7816e39ee5ed504a69cb8037f10.tar.bz2 linux-59104f062435c7816e39ee5ed504a69cb8037f10.zip |
ip: take care of last fragment in ip_append_data
While investigating a bit, I found ip_fragment() slow path was taken
because ip_append_data() provides following layout for a send(MTU +
N*(MTU - 20)) syscall :
- one skb with 1500 (mtu) bytes
- N fragments of 1480 (mtu-20) bytes (before adding IP header)
last fragment gets 17 bytes of trail data because of following bit:
if (datalen == length + fraggap)
alloclen += rt->dst.trailer_len;
Then esp4 adds 16 bytes of data (while trailer_len is 17... hmm...
another bug ?)
In ip_fragment(), we notice last fragment is too big (1496 + 20) > mtu,
so we take slow path, building another skb chain.
In order to avoid taking slow path, we should correct ip_append_data()
to make sure last fragment has real trail space, under mtu...
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'security/selinux')
0 files changed, 0 insertions, 0 deletions