diff options
| author | Ondrej Mosnacek <omosnace@redhat.com> | 2024-04-04 17:16:19 +0200 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2024-04-04 16:38:37 -0400 |
| commit | 4e551db0426472ca305a2f3284b25af763bfe57d (patch) | |
| tree | bc5340f3da2df7a18680544712d204f1418ba794 /security | |
| parent | abb0f43fcdf2cde0beaf6bbe34723a3dca9f125b (diff) | |
| download | linux-4e551db0426472ca305a2f3284b25af763bfe57d.tar.gz linux-4e551db0426472ca305a2f3284b25af763bfe57d.tar.bz2 linux-4e551db0426472ca305a2f3284b25af763bfe57d.zip | |
selinux: clarify return code in filename_trans_read_helper_compat()
For the "conflicting/duplicate rules" branch in
filename_trans_read_helper_compat() the Smatch static checker reports:
security/selinux/ss/policydb.c:1953 filename_trans_read_helper_compat()
warn: missing error code 'rc'
While the value of rc will already always be zero here, it is not
obvious that it's the case and that it's the intended return value
(Smatch expects rc to be assigned within 5 lines from the goto).
Therefore, add an explicit assignment just before the goto to make the
intent more clear and the code less error-prone.
Fixes: c3a276111ea2 ("selinux: optimize storage of filename transitions")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/selinux/722b90c4-1f4b-42ff-a6c2-108ea262bd10@moroto.mountain/
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/selinux/ss/policydb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c index 9a23362c42f4..383f3ae82a73 100644 --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -1950,6 +1950,7 @@ static int filename_trans_read_helper_compat(struct policydb *p, void *fp) if (unlikely(ebitmap_get_bit(&datum->stypes, stype - 1))) { /* conflicting/duplicate rules are ignored */ datum = NULL; + rc = 0; goto out; } if (likely(datum->otype == otype)) |