summaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorPaul Moore <paul@paul-moore.com>2022-01-27 10:45:59 -0500
committerPaul Moore <paul@paul-moore.com>2022-01-27 12:52:43 -0500
commitcdeea45422f579b9302e377d1ede29133d3fde8e (patch)
tree88ec6e174874d9b7262f9c9f6ee8fb8487ed3c19 /security
parentb5e68162f859132af419af479bdb96e2ae18fa2b (diff)
downloadlinux-cdeea45422f579b9302e377d1ede29133d3fde8e.tar.gz
linux-cdeea45422f579b9302e377d1ede29133d3fde8e.tar.bz2
linux-cdeea45422f579b9302e377d1ede29133d3fde8e.zip
selinux: fix a type cast problem in cred_init_security()
In the process of removing an explicit type cast to preserve a cred const qualifier in cred_init_security() we ran into a problem where the task_struct::real_cred field is defined with the "__rcu" attribute but the selinux_cred() function parameter is not, leading to a sparse warning: security/selinux/hooks.c:216:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct cred const *cred @@ got struct cred const [noderef] __rcu *real_cred As we don't want to add the "__rcu" attribute to the selinux_cred() parameter, we're going to add an explicit cast back to cred_init_security(). Fixes: b084e189b01a ("selinux: simplify cred_init_security") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security')
-rw-r--r--security/selinux/hooks.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index eae7dbd62df1..221e642025f5 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -213,7 +213,7 @@ static void cred_init_security(void)
{
struct task_security_struct *tsec;
- tsec = selinux_cred(current->real_cred);
+ tsec = selinux_cred(unrcu_pointer(current->real_cred));
tsec->osid = tsec->sid = SECINITSID_KERNEL;
}