diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-10-14 00:19:52 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-10-23 13:29:47 +0100 |
| commit | d0cc676c426d1958989fac2a0d45179fb9992f0a (patch) | |
| tree | 23994435043ac4b0bf1ee627fa7f416b9a2efe3c /sound/soc/qcom/lpass-ipq806x.c | |
| parent | 8210f496c3e12410fa240c7fbc63f71ef78e253f (diff) | |
| download | linux-d0cc676c426d1958989fac2a0d45179fb9992f0a.tar.gz linux-d0cc676c426d1958989fac2a0d45179fb9992f0a.tar.bz2 linux-d0cc676c426d1958989fac2a0d45179fb9992f0a.zip | |
ASoC: qcom: lpass: Make asoc_qcom_lpass_cpu_platform_remove() return void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
asoc_qcom_lpass_cpu_platform_remove() returned zero unconditionally.
Make it return void instead and convert all users to struct
platform_device::remove_new().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231013221945.1489203-15-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/qcom/lpass-ipq806x.c')
| -rw-r--r-- | sound/soc/qcom/lpass-ipq806x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/qcom/lpass-ipq806x.c b/sound/soc/qcom/lpass-ipq806x.c index bbe9f11d7780..e0e9ad35821c 100644 --- a/sound/soc/qcom/lpass-ipq806x.c +++ b/sound/soc/qcom/lpass-ipq806x.c @@ -172,7 +172,7 @@ static struct platform_driver ipq806x_lpass_cpu_platform_driver = { .of_match_table = of_match_ptr(ipq806x_lpass_cpu_device_id), }, .probe = asoc_qcom_lpass_cpu_platform_probe, - .remove = asoc_qcom_lpass_cpu_platform_remove, + .remove_new = asoc_qcom_lpass_cpu_platform_remove, }; module_platform_driver(ipq806x_lpass_cpu_platform_driver); |