diff options
| author | Camel Guo <camelg@axis.com> | 2020-09-01 15:57:35 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-09-01 16:04:40 +0100 |
| commit | 2569231d71dff82cfd6e82ab3871776f72ec53b6 (patch) | |
| tree | b273a8352d25f32315f3b46e1403b348af96692a /sound | |
| parent | f5a2cda4f1db89776b64c4f0f2c2ac609527ac70 (diff) | |
| download | linux-2569231d71dff82cfd6e82ab3871776f72ec53b6.tar.gz linux-2569231d71dff82cfd6e82ab3871776f72ec53b6.tar.bz2 linux-2569231d71dff82cfd6e82ab3871776f72ec53b6.zip | |
ASoC: tlv320adcx140: Fix accessing uninitialized adcx140->dev
In adcx140_i2c_probe, adcx140->dev is accessed before its
initialization. This commit fixes this bug.
Fixes: 689c7655b50c ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family")
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Camel Guo <camel.guo@axis.com>
Link: https://lore.kernel.org/r/20200901135736.32036-1-camel.guo@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/tlv320adcx140.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c index 5cd50d841177..7ae6ec374be3 100644 --- a/sound/soc/codecs/tlv320adcx140.c +++ b/sound/soc/codecs/tlv320adcx140.c @@ -980,6 +980,8 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, if (!adcx140) return -ENOMEM; + adcx140->dev = &i2c->dev; + adcx140->gpio_reset = devm_gpiod_get_optional(adcx140->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(adcx140->gpio_reset)) @@ -1007,7 +1009,7 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, ret); return ret; } - adcx140->dev = &i2c->dev; + i2c_set_clientdata(i2c, adcx140); return devm_snd_soc_register_component(&i2c->dev, |