diff options
| author | Dylan Reid <dgreid@chromium.org> | 2013-03-14 17:27:45 -0700 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2013-03-15 07:40:39 +0100 |
| commit | e8f1bd5d77484a1088797fd5689b1a37148a170e (patch) | |
| tree | 127733b992fb9a804db9d5a48a817b377806196c /sound | |
| parent | d1d28500cccc269fdbf81ba33d7328d1d2c04b2f (diff) | |
| download | linux-e8f1bd5d77484a1088797fd5689b1a37148a170e.tar.gz linux-e8f1bd5d77484a1088797fd5689b1a37148a170e.tar.bz2 linux-e8f1bd5d77484a1088797fd5689b1a37148a170e.zip | |
ALSA: hda/ca0132 - Check download state of DSP.
Instead of using the dspload_is_loaded() function, check the dsp_state
that is kept in the spec. The dspload_is_loaded() function returns
true if the DSP transfer was never started. This false-positive leads
to multiple second delays when ca0132_setup_efaults() times out on
each write.
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/pci/hda/patch_ca0132.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index cf24b75108d9..225d1d52abad 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -3239,7 +3239,7 @@ static int ca0132_set_vipsource(struct hda_codec *codec, int val) struct ca0132_spec *spec = codec->spec; unsigned int tmp; - if (!dspload_is_loaded(codec)) + if (spec->dsp_state != DSP_DOWNLOADED) return 0; /* if CrystalVoice if off, vipsource should be 0 */ @@ -4267,11 +4267,12 @@ static void ca0132_refresh_widget_caps(struct hda_codec *codec) */ static void ca0132_setup_defaults(struct hda_codec *codec) { + struct ca0132_spec *spec = codec->spec; unsigned int tmp; int num_fx; int idx, i; - if (!dspload_is_loaded(codec)) + if (spec->dsp_state != DSP_DOWNLOADED) return; /* out, in effects + voicefx */ |