diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-04-18 21:24:16 +0900 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2017-01-26 11:43:00 -0300 |
commit | a7619aef6dca913d830675dd914ca6fe7241a730 (patch) | |
tree | 2490aac9e21e07197f2ce79a2be45d6b33148f5d /tools/perf/util/trace-event-read.c | |
parent | cd4ceb63438e9e28299f4352ae7b75d2967a772d (diff) | |
download | linux-a7619aef6dca913d830675dd914ca6fe7241a730.tar.gz linux-a7619aef6dca913d830675dd914ca6fe7241a730.tar.bz2 linux-a7619aef6dca913d830675dd914ca6fe7241a730.zip |
perf util: Add more debug message on failure path
It's helpful for debugging on tracing features.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jeremy Eder <jeder@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/n/tip-rjysr9ljiesymgk4qblteaty@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/trace-event-read.c')
-rw-r--r-- | tools/perf/util/trace-event-read.c | 53 |
1 files changed, 36 insertions, 17 deletions
diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c index 61c7162c31c7..27420159bf69 100644 --- a/tools/perf/util/trace-event-read.c +++ b/tools/perf/util/trace-event-read.c @@ -260,39 +260,53 @@ static int read_header_files(struct pevent *pevent) static int read_ftrace_file(struct pevent *pevent, unsigned long long size) { + int ret; char *buf; buf = malloc(size); - if (buf == NULL) + if (buf == NULL) { + pr_debug("memory allocation failure\n"); return -1; + } - if (do_read(buf, size) < 0) { - free(buf); - return -1; + ret = do_read(buf, size); + if (ret < 0) { + pr_debug("error reading ftrace file.\n"); + goto out; } - parse_ftrace_file(pevent, buf, size); + ret = parse_ftrace_file(pevent, buf, size); + if (ret < 0) + pr_debug("error parsing ftrace file.\n"); +out: free(buf); - return 0; + return ret; } static int read_event_file(struct pevent *pevent, char *sys, unsigned long long size) { + int ret; char *buf; buf = malloc(size); - if (buf == NULL) + if (buf == NULL) { + pr_debug("memory allocation failure\n"); return -1; + } - if (do_read(buf, size) < 0) { + ret = do_read(buf, size); + if (ret < 0) { free(buf); - return -1; + goto out; } - parse_event_file(pevent, buf, size, sys); + ret = parse_event_file(pevent, buf, size, sys); + if (ret < 0) + pr_debug("error parsing event file.\n"); +out: free(buf); - return 0; + return ret; } static int read_ftrace_files(struct pevent *pevent) @@ -345,6 +359,7 @@ static int read_saved_cmdline(struct pevent *pevent) { unsigned long long size; char *buf; + int ret; /* it can have 0 size */ size = read8(pevent); @@ -352,18 +367,22 @@ static int read_saved_cmdline(struct pevent *pevent) return 0; buf = malloc(size + 1); - if (buf == NULL) + if (buf == NULL) { + pr_debug("memory allocation failure\n"); return -1; + } - if (do_read(buf, size) < 0) { - free(buf); - return -1; + ret = do_read(buf, size); + if (ret < 0) { + pr_debug("error reading saved cmdlines\n"); + goto out; } parse_saved_cmdline(pevent, buf, size); - + ret = 0; +out: free(buf); - return 0; + return ret; } ssize_t trace_report(int fd, struct trace_event *tevent, bool __repipe) |