diff options
| author | Sherry Hurwitz <sherry.hurwitz@amd.com> | 2017-06-20 02:07:37 -0500 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2017-06-27 01:43:21 +0200 |
| commit | 6ae78b4e7c276e5306897269443f66cb4d86e47f (patch) | |
| tree | c514eb94173126eb2a79fdb192286b1f3459380e /tools/power | |
| parent | 5422583bfa6cb09fdc6955b88f647011a83186fb (diff) | |
| download | linux-6ae78b4e7c276e5306897269443f66cb4d86e47f.tar.gz linux-6ae78b4e7c276e5306897269443f66cb4d86e47f.tar.bz2 linux-6ae78b4e7c276e5306897269443f66cb4d86e47f.zip | |
cpupower: Fix bug where return value was not used
Save return value from amd_pci_get_num_boost_states
and remove redundant setting of *support
Signed-off-by: Sherry Hurwitz <sherry.hurwitz@amd.com>
Reviewed-by: Thomas Renninger <trenn@suse.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'tools/power')
| -rw-r--r-- | tools/power/cpupower/utils/helpers/misc.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c index 1609243f5c64..6952a6abd1e5 100644 --- a/tools/power/cpupower/utils/helpers/misc.c +++ b/tools/power/cpupower/utils/helpers/misc.c @@ -16,10 +16,9 @@ int cpufreq_has_boost_support(unsigned int cpu, int *support, int *active, if (cpupower_cpu_info.caps & CPUPOWER_CAP_AMD_CBP) { *support = 1; - amd_pci_get_num_boost_states(active, states); - if (ret <= 0) + ret = amd_pci_get_num_boost_states(active, states); + if (ret) return ret; - *support = 1; } else if (cpupower_cpu_info.caps & CPUPOWER_CAP_INTEL_IDA) *support = *active = 1; return 0; |