diff options
author | Ingo Molnar <mingo@kernel.org> | 2015-04-12 11:11:21 +0200 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2015-04-12 11:21:15 +0200 |
commit | 066450be419fa48007a9f29e19828f2a86198754 (patch) | |
tree | 8dcc666fb88b9e6f472ccad4fed9f1d57d538938 /tools | |
parent | 5dafd7cb96ec75454eb1fcbf993000bf41175f13 (diff) | |
download | linux-066450be419fa48007a9f29e19828f2a86198754.tar.gz linux-066450be419fa48007a9f29e19828f2a86198754.tar.bz2 linux-066450be419fa48007a9f29e19828f2a86198754.zip |
perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init()
Dan Carpenter pointed out that the control flow in pt_pmu_hw_init()
is a bit messy: for example the kfree(de_attrs) is entirely
superfluous.
Another problem is the inconsistent mixing of label based and
direct return error handling.
Add modern, label based error handling instead and clean up the code
a bit as well.
Note that we'll still do a kfree(NULL) in the normal case - this does
not matter as this is an init path and kfree() returns early if it
sees a NULL.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20150409090805.GG17605@mwanda
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions