diff options
author | Stanislav Fomichev <sdf@google.com> | 2019-08-30 19:34:26 -0700 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2019-09-03 15:13:14 +0200 |
commit | d80507d15d45e285fc596d23665c9b88cf0dfec3 (patch) | |
tree | 2c3d5c5ca47d649db2a21bdbb00a459cba133efa /tools | |
parent | bdb15a29cc28f8155e20f7fb58b60ffc452f2d1b (diff) | |
download | linux-d80507d15d45e285fc596d23665c9b88cf0dfec3.tar.gz linux-d80507d15d45e285fc596d23665c9b88cf0dfec3.tar.bz2 linux-d80507d15d45e285fc596d23665c9b88cf0dfec3.zip |
selftests/bpf: test_progs: fix verbose mode garbage
fseeko(.., 0, SEEK_SET) on a memstream just puts the buffer pointer
to the beginning so when we call fflush on it we get some garbage
log data from the previous test. Let's manually set terminating
byte to zero at the reported buffer size.
To show the issue consider the following snippet:
stream = open_memstream (&buf, &len);
fprintf(stream, "aaa");
fflush(stream);
printf("buf=%s, len=%zu\n", buf, len);
fseeko(stream, 0, SEEK_SET);
fprintf(stream, "b");
fflush(stream);
printf("buf=%s, len=%zu\n", buf, len);
Output:
buf=aaa, len=3
buf=baa, len=1
Fixes: 946152b3c5d6 ("selftests/bpf: test_progs: switch to open_memstream")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/testing/selftests/bpf/test_progs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c index e5892cb60eca..e8616e778cb5 100644 --- a/tools/testing/selftests/bpf/test_progs.c +++ b/tools/testing/selftests/bpf/test_progs.c @@ -45,6 +45,7 @@ static void dump_test_log(const struct prog_test_def *test, bool failed) if (env.verbose || test->force_log || failed) { if (env.log_cnt) { + env.log_buf[env.log_cnt] = '\0'; fprintf(env.stdout, "%s", env.log_buf); if (env.log_buf[env.log_cnt - 1] != '\n') fprintf(env.stdout, "\n"); |