diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-08-05 12:37:21 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-08-09 10:46:56 -0300 |
| commit | 887fa86d6fd7a45cee2d0f9d5f75026786d61df2 (patch) | |
| tree | 8aaaa2152b4607a5fe2ef885785d8d6a56d9d186 /tools | |
| parent | bcdc09af3ef30ef071677544ce23a1c8873a2dda (diff) | |
| download | linux-887fa86d6fd7a45cee2d0f9d5f75026786d61df2.tar.gz linux-887fa86d6fd7a45cee2d0f9d5f75026786d61df2.tar.bz2 linux-887fa86d6fd7a45cee2d0f9d5f75026786d61df2.zip | |
perf hists: Trim libtraceevent trace_seq buffers
When we use libtraceevent to format trace event fields into printable
strings to use in hist entries it is important to trim it from the
default 4 KiB it starts with to what is really used, to reduce the
memory footprint, so use realloc(seq.buffer, seq.len + 1) when returning
the seq.buffer formatted with the fields contents.
Reported-and-Tested-by: Wang Nan <wangnan0@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/tip-t3hl7uxmilrkigzmc90rlhk2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/sort.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 947d21f38398..3d3cb8392c86 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -588,7 +588,11 @@ static char *get_trace_output(struct hist_entry *he) } else { pevent_event_info(&seq, evsel->tp_format, &rec); } - return seq.buffer; + /* + * Trim the buffer, it starts at 4KB and we're not going to + * add anything more to this buffer. + */ + return realloc(seq.buffer, seq.len + 1); } static int64_t |