diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-20 13:08:46 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-21 23:07:36 -0200 |
| commit | fc551f8d4427150da1ee7cbb0f53525c49ef4bca (patch) | |
| tree | 87aaf6b20a79fb2b87e5e7bac2f138f9a7738444 /tools | |
| parent | 3a531260a14631ae8d231279b8738884bf808e7b (diff) | |
| download | linux-fc551f8d4427150da1ee7cbb0f53525c49ef4bca.tar.gz linux-fc551f8d4427150da1ee7cbb0f53525c49ef4bca.tar.bz2 linux-fc551f8d4427150da1ee7cbb0f53525c49ef4bca.zip | |
perf trace: Check if sample raw_data field is set
Sometimes we're segfaulting because we were expecting that the
perf_sample.raw_data field was set as requested, but in some cases
that needs further investigation, that field can be NULL, leading
to segfaults.
Make the tool more robust by checking that before calling any per event
handlers that may try to use that field.
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-g1fmodl6ys4lq8honbj1igoi@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/builtin-trace.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 83c6515e425d..7aaee39f6774 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -268,6 +268,13 @@ again: if (evlist->threads->map[0] == -1 || evlist->threads->nr > 1) printf("%d ", sample.tid); + if (sample.raw_data == NULL) { + printf("%s sample with no payload for tid: %d, cpu %d, raw_size=%d, skipping...\n", + perf_evsel__name(evsel), sample.tid, + sample.cpu, sample.raw_size); + continue; + } + handler = evsel->handler.func; handler(trace, evsel, &sample); } |