diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-09-23 16:22:22 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-09-25 09:51:48 -0300 |
| commit | 26049111c333fda4194e895f4cb719766b602256 (patch) | |
| tree | a0ff9fdff2045849537f168c502c053868db35fd /tools | |
| parent | 20f2be1d48ec293b5a935595bd0c2e2915ffa77c (diff) | |
| download | linux-26049111c333fda4194e895f4cb719766b602256.tar.gz linux-26049111c333fda4194e895f4cb719766b602256.tar.bz2 linux-26049111c333fda4194e895f4cb719766b602256.zip | |
perf tools: No need to include internal/lib.h from util/util.h
That was done just to have users of writen() and readn(), that before
had their prototypes in util/util.h to get it without having to add an
include for internal/lib.h, but the right way is to add it and by now
all places already do it.
Fix a fallout were readlink() was used but unistd.h was being obtained
by luck thru util.h -> internal/lib.h, now to check why unistd.h is
being included there...
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-lcnytgrtafey3kwlfog2rzzj@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/tests/sdt.c | 1 | ||||
| -rw-r--r-- | tools/perf/util/util.h | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/tests/sdt.c b/tools/perf/tests/sdt.c index cf1bd57d3023..60f0e9ee04fb 100644 --- a/tools/perf/tests/sdt.c +++ b/tools/perf/tests/sdt.c @@ -3,6 +3,7 @@ #include <limits.h> #include <stdio.h> #include <stdlib.h> +#include <unistd.h> #include <sys/epoll.h> #include <util/symbol.h> #include <linux/filter.h> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h index d6ae394e67c4..b78b73e5bb32 100644 --- a/tools/perf/util/util.h +++ b/tools/perf/util/util.h @@ -11,7 +11,6 @@ #include <stddef.h> #include <linux/compiler.h> #include <sys/types.h> -#include <internal/lib.h> /* General helper functions */ void usage(const char *err) __noreturn; |