summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* unexport do_mmap()Al Viro2012-05-302-2/+0
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* ia64 perfmon: fix get_unmapped_area() use thereAl Viro2012-05-301-8/+2
| | | | | | | get_unmapped_area() returns -E... on failure, not 0. Moreover, the wrapper around it is completely pointless. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* merge do_mremap() into sys_mremap()Al Viro2012-05-301-14/+5
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* ia64, sparc64: convert wrappers around do_mremap() to sys_mremap()Al Viro2012-05-302-25/+5
| | | | | | they contain open-coded sys_mremap() Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* binfmt_flat: use vm_munmap, we are missing ->mmap_sem thereAl Viro2012-05-301-4/+4
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* binfmt_elf: switch elf_map() to vm_mmap/vm_munmapAl Viro2012-05-301-5/+3
| | | | | | No reason to hold ->mmap_sem over the sequence Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* vfs: umount_tree() might be called on subtree that had never made itAl Viro2012-05-301-1/+2
| | | | | | | | | | __mnt_make_shortterm() in there undoes the effect of __mnt_make_longterm() we'd done back when we set ->mnt_ns non-NULL; it should not be done to vfsmounts that had never gone through commit_tree() and friends. Kudos to lczerner for catching that one... Cc: stable@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl commandWill Deacon2012-05-301-1/+1
| | | | | | | | | | | | | | | | As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl command which they don't understand. Doing so will result in -ENOTTY being returned to userspace, which matches the behaviour of the compat layer if it fails to translate an ioctl command. This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of -EINVAL when passed an unknown ioctl command. Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* vfs: remove unused __d_splice_alias argumentJ. Bruce Fields2012-05-301-8/+5
| | | | | | | | Nobody sets want_disconn any more. Reported-by: Peng Tao <bergwolf@gmail.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* vfs: stop d_splice_alias creating directory aliasesJ. Bruce Fields2012-05-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A directory should never have more than one dentry pointing to it. But d_splice_alias() will add one if it finds a directory with an already-existing non-DISCONNECTED dentry. I can't find an obvious reproducer, but I also can't see what prevents d_splice_alias() from encountering such a case. It therefore seems safest to allow d_splice_alias to use any dentry it finds. (Prior to the removal of dentry_unhash() from vfs_rmdir(), around v3.0, this could cause an nfsd deadlock like this: - Somebody attempts to remove a non-empty directory. - The dentry_unhash() in vfs_rmdir() unhashes the dentry pointing to the non-empty directory. - ->rmdir() then fails with -ENOTEMPTY - Before the vfs_rmdir() caller reaches dput(), an nfsd process in rename looks up the directory by filehandle; at the end of that lookup, this dentry is found by d_alloc_anon(), and a reference is taken on it, preventing dput() from removing it. - A regular lookup of the directory calls d_splice_alias(), finds only an unhashed (not a DISCONNECTED) dentry, and insteads adds a new one, so the directory now has two dentries. - The nfsd process in rename, which was previously looking up the source directory of the rename, now looks up the target directory (which is the same), and gets the dentry newly created by the previous lookup. - The rename, seeing two different dentries, assumes this is a cross-directory rename and attempts to take the i_mutex on the directory twice. That reproducer no longer exists, but I don't think there was anything fundamentally incorrect about the vfs_rmdir() behavior there, so I think the real fault was here in d_splice_alias().) Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* i810: switch to vm_mmap()Al Viro2012-05-301-3/+1
| | | | | | | | Weirdness around do_mmap() in there does not rely on ->mmap_sem for exclusion, so no need to keep it under that. As the result, we can turn that do_mmap() into vm_mmap(). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* fsnotify: remove unused parameter from send_to_group()Dan Carpenter2012-05-301-6/+6
| | | | | | | | | | We don't use "mnt" anymore in send_to_group() after 1968f5eed5 ("fanotify: use both marks when possible") was applied. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* fsnotify: handle subfiles' perm eventsNaohiro Aota2012-05-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recently I'm working on fanotify and found the following strange behaviors. I wrote a program to set fanotify_mark on "/tmp/block" and FAN_DENY all events notified. fanotify_mask = FAN_ALL_EVENTS | FAN_ALL_PERM_EVENTS | FAN_EVENT_ON_CHILD: $ cd /tmp/block; cat foo cat: foo: Operation not permitted Operation on the file is blocked as expected. But, fanotify_mask = FAN_ALL_PERM_EVENTS | FAN_EVENT_ON_CHILD: $ cd /tmp/block; cat foo aaa It's not blocked anymore. This is confusing behavior. Also reading commit "fsnotify: call fsnotify_parent in perm events", it seems like fsnotify should handle subfiles' perm events as well as the other notify events. With this patch, regardless of FAN_ALL_EVENTS set or not: $ cd /tmp/block; cat foo cat: foo: Operation not permitted Operation on the file is now blocked properly. FS_OPEN_PERM and FS_ACCESS_PERM are not listed on FS_EVENTS_POSS_ON_CHILD. Due to fsnotify_inode_watches_children() check, if you only specify only these events as fsnotify_mask, you don't get subfiles' perm events notified. This patch add the events to FS_EVENTS_POSS_ON_CHILD to get them notified even if only these events are specified to fsnotify_mask. Signed-off-by: Naohiro Aota <naota@elisp.net> Cc: Eric Paris <eparis@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* vfs: increment iversion when a file is truncatedDmitry Kasatkin2012-05-301-0/+5
| | | | | | | | | | | | | | | | | | | | | When a file is truncated with truncate()/ftruncate() and then closed, iversion is not updated. This patch uses ATTR_SIZE flag as an indication to increment iversion. Mimi said: On fput(), i_version is used to detect and flag files that have changed and need to be re-measured in the IMA measurement policy. When a file is truncated with truncate()/ftruncate() and then closed, i_version is not updated. As a result, although the file has changed, it will not be re-measured and added to the IMA measurement list on subsequent access. Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@intel.com> Acked-by: Mimi Zohar <zohar@us.ibm.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* fs: Move bh_cachep to the __read_mostly sectionShai Fultheim2012-05-301-1/+1
| | | | | | | | | bh_cachep is only written to once on initialization, so move it to the __read_mostly section. Signed-off-by: Shai Fultheim <shai@scalemp.com> Signed-off-by: Vlad Zolotarov <vlad@scalemp.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* fs: move file_remove_suid() to fs/inode.cCong Wang2012-05-302-65/+65
| | | | | | | | | file_remove_suid() is a generic function operates on struct file, it almost has no relations with file mapping, so move it to fs/inode.c. Cc: Alexander Viro <viro@zeniv.linux.org.uk> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* jffs2: get rid of jffs2_sync_superArtem Bityutskiy2012-05-304-21/+58
| | | | | | | | | | | | | | | | | | | | | Currently JFFS2 file-system maps the VFS "superblock" abstraction to the write-buffer. Namely, it uses VFS services to synchronize the write-buffer periodically. The whole "superblock write-out" VFS infrastructure is served by the 'sync_supers()' kernel thread, which wakes up every 5 (by default) seconds and writes out all dirty superblock using the '->write_super()' call-back. But the problem with this thread is that it wastes power by waking up the system every 5 seconds no matter what. So we want to kill it completely and thus, we need to make file-systems to stop using the '->write_super' VFS service, and then remove it together with the kernel thread. This patch switches the JFFS2 write-buffer management from '->write_super()'/'->s_dirt' to a delayed work. Instead of setting the 's_dirt' flag we just schedule a delayed work for synchronizing the write-buffer. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* jffs2: remove unnecessary GC pass on syncArtem Bityutskiy2012-05-301-2/+0
| | | | | | | | | | | | | | | We do not need to call 'jffs2_write_super()' on sync. This function causes a GC pass to make sure the current contents is pushed out with the data which we already have on the media. But this is not needed on unmount and only slows sync down unnecessarily. It is enough to just sync the write-buffer. This call was added by one of the generic VFS rework patch-sets, see d579ed00aa96a7f7486978540a0d7cecaff742ae. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* jffs2: remove unnecessary GC pass on umountArtem Bityutskiy2012-05-301-3/+0
| | | | | | | | | | | | | | | We do not need to call 'jffs2_write_super()' on unmount. This function causes a GC pass to make sure the current contents is pushed out with the data which we already have on the media. But this is not needed on unmount and only slows unmount down unnecessarily. It is enough to just sync the write-buffer. This call was added by one of the generic VFS rework patch-sets, see 8c85e125124a473d6f3e9bb187b0b84207f81d91. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* jffs2: remove lock_superArtem Bityutskiy2012-05-301-3/+0
| | | | | | | We do not need 'lock_super()'/'unlock_super()' in JFFS2 - kill them. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* bury __kernel_nlink_t, make internal nlink_t consistentAl Viro2012-05-3022-65/+1
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* parisc: get rid of nlink_t, switch to explicitly-sized typeAl Viro2012-05-301-2/+2
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* powerpc: get rid of nlink_t uses, switch to explicitly-sized typeAl Viro2012-05-301-2/+2
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* mips: get rid of nlink_t, use explictly-sized type (__u32 in all cases)Al Viro2012-05-291-3/+3
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* mode_t whack-a-mole: ->is_visible() returns umode_t...Al Viro2012-05-291-1/+1
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* get rid of idiotic misplaced __kernel_mode_t in ncfps kernel-private data ↵Al Viro2012-05-291-5/+5
| | | | | | structure Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* brlocks/lglocks: API cleanupsAndi Kleen2012-05-296-95/+96
| | | | | | | | | | | | | | | | | | | | | lglocks and brlocks are currently generated with some complicated macros in lglock.h. But there's no reason to not just use common utility functions and put all the data into a common data structure. In preparation, this patch changes the API to look more like normal function calls with pointers, not magic macros. The patch is rather large because I move over all users in one go to keep it bisectable. This impacts the VFS somewhat in terms of lines changed. But no actual behaviour change. [akpm@linux-foundation.org: checkpatch fixes] Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* brlocks/lglocks: turn into functionsAndi Kleen2012-05-295-102/+117
| | | | | | | | | | | | | | | | | | | | | lglocks and brlocks are currently generated with some complicated macros in lglock.h. But there's no reason to not just use common utility functions and put all the data into a common data structure. Since there are at least two users it makes sense to share this code in a library. This is also easier maintainable than a macro forest. This will also make it later possible to dynamically allocate lglocks and also use them in modules (this would both still need some additional, but now straightforward, code) [akpm@linux-foundation.org: checkpatch fixes] Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* lglock: remove online variants of lockRusty Russell2012-05-291-56/+2
| | | | | | | | | Optimizing the slow paths adds a lot of complexity. If you need to grab every lock often, you have other problems. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Acked-by: Nick Piggin <npiggin@kernel.dk> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* ocfs: simplify symlink handlingAl Viro2012-05-294-104/+31
| | | | | | | | seeing that "fast" symlinks still get allocation + copy, we might as well simply switch them to pagecache-based variant of ->follow_link(); just need an appropriate ->readpage() for them... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* get rid of pointless allocations and copying in ecryptfs_follow_link()Al Viro2012-05-291-39/+9
| | | | | | switch to generic_readlink(), while we are at it Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: assorted endianness annotationsAl Viro2012-05-294-60/+60
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: annotate eaAl Viro2012-05-291-2/+2
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: annotate struct hpfs_direntAl Viro2012-05-293-12/+12
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: annotate struct anodeAl Viro2012-05-291-4/+4
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: annotate struct fnodeAl Viro2012-05-291-14/+14
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: annotate btree nodes, get rid of bitfields messAl Viro2012-05-293-51/+52
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: annotate struct dnodeAl Viro2012-05-291-4/+4
| | | | | | little-endians... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: bitmaps are little-endianAl Viro2012-05-293-12/+12
| | | | | | annotate properly... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: get rid of bitfields in struct fnodeAl Viro2012-05-298-38/+32
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: get rid of bitfields endianness wanking in extended_attributeAl Viro2012-05-293-34/+35
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* fs: fix inode.c kernel-doc warningsRandy Dunlap2012-05-291-2/+1
| | | | | | | | | | | Fix kernel-doc warnings in fs/inode.c: Warning(fs/inode.c:1493): No description found for parameter 'path' Warning(fs/inode.c:1493): Excess function parameter 'mnt' description in 'touch_atime' Warning(fs/inode.c:1493): Excess function parameter 'dentry' description in 'touch_atime' Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* hpfs: endianness bugsAl Viro2012-05-292-3/+3
| | | | | | | a couple of le32 and le16 used with wrong le..._to_cpu(), plus idiotic use of le32_to_cpu() on 1-bit bitfield Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* btrfs: trivial endianness annotationsAl Viro2012-05-293-7/+8
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* ocfs2: kill endianness abuses in blockcheck.cAl Viro2012-05-291-20/+22
| | | | | | | | ocfs2_block_check is for little-endian contents; if we just want to its fields converted to host-endian in a couple of functions, just put those values into local u32 and u16... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* ocfs2: deal with __user misannotationsAl Viro2012-05-292-21/+16
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* ocfs2: trivial endianness misannotationsAl Viro2012-05-293-5/+5
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* affs: bury unused macrosAl Viro2012-05-291-8/+0
| | | | | | ... unused since 2.4.4. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* kill v9fs_dentry_from_dir_inode()Al Viro2012-05-291-21/+3
| | | | | | | In *all* callers we have a dentry of child of that directory. Just use ->d_parent of that one, for fsck sake... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* selinuxfs snprintf() misusesAl Viro2012-05-291-29/+7
| | | | | | | | a) %d does _not_ produce a page worth of output b) snprintf() doesn't return negatives - it used to in old glibc, but that's the kernel... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-18 01:11:40 +0000