From c968ed08594dadb788a93dc2bc128ed4ef35c93e Mon Sep 17 00:00:00 2001 From: "Luck, Tony" Date: Fri, 14 Sep 2018 13:19:05 -0700 Subject: EDAC, sb_edac: Fix signedness bugs in *_get_ha() functions A static checker gave the following warnings: drivers/edac/sb_edac.c:1030 ibridge_get_ha() warn: signedness bug returning '(-22)' drivers/edac/sb_edac.c:1037 knl_get_ha() warn: signedness bug returning '(-22)' Both because the functions are declared to return a "u8", but try to return -EINVAL for the error case. Fix by returning 0xff (since the caller doesn't look at, or pass on, the return value). Reported-by: Dan Carpenter Signed-off-by: Tony Luck Cc: Qiuxu Zhuo Cc: linux-edac Link: http://lkml.kernel.org/r/20180914201905.GA30946@agluck-desk Signed-off-by: Borislav Petkov --- drivers/edac/sb_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/edac') diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index d4a10793f807..5aeb9a1ee898 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c @@ -1027,14 +1027,14 @@ static u8 ibridge_get_ha(u8 bank) case 9 ... 16: return (bank - 9) / 4; default: - return -EINVAL; + return 0xff; } } /* Not used, but included for safety/symmetry */ static u8 knl_get_ha(u8 bank) { - return -EINVAL; + return 0xff; } static u64 haswell_get_tolm(struct sbridge_pvt *pvt) -- cgit v1.2.3