From 709340a00ad67aea081916582846248e3b18b463 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 5 Jul 2017 13:47:34 +0100 Subject: cifs: set oparms.create_options rather than or'ing in CREATE_OPEN_BACKUP_INTENT Currently oparms.create_options is uninitialized and the code is logically or'ing in CREATE_OPEN_BACKUP_INTENT onto a garbage value of oparms.create_options from the stack. Fix this by just setting the value rather than or'ing in the setting. Detected by CoverityScan, CID#1447220 ("Unitialized scale value") Signed-off-by: Colin Ian King Signed-off-by: Steve French Reviewed-by: Pavel Shilovsky --- fs/cifs/smb2ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/cifs/smb2ops.c') diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 323bafdd7909..ccbb397debbc 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1339,7 +1339,7 @@ get_smb2_acl_by_path(struct cifs_sb_info *cifs_sb, xid = get_xid(); if (backup_cred(cifs_sb)) - oparms.create_options |= CREATE_OPEN_BACKUP_INTENT; + oparms.create_options = CREATE_OPEN_BACKUP_INTENT; else oparms.create_options = 0; -- cgit v1.2.3