From d1f0a5e1fb4e2f2f603bec8df79ca51768f2bdae Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Mon, 19 Apr 2021 13:03:45 -0700 Subject: ethtool: stats: clarify the initialization to ETHTOOL_STAT_NOT_SET Ido suggests we add a comment about the init of stats to -1. This is unlikely to be clear to first time readers. Suggested-by: Ido Schimmel Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller --- net/ethtool/stats.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'net/ethtool/stats.c') diff --git a/net/ethtool/stats.c b/net/ethtool/stats.c index acb2b080c358..b7642dc96d50 100644 --- a/net/ethtool/stats.c +++ b/net/ethtool/stats.c @@ -114,6 +114,9 @@ static int stats_prepare_data(const struct ethnl_req_info *req_base, if (ret < 0) return ret; + /* Mark all stats as unset (see ETHTOOL_STAT_NOT_SET) to prevent them + * from being reported to user space in case driver did not set them. + */ memset(&data->phy_stats, 0xff, sizeof(data->phy_stats)); memset(&data->mac_stats, 0xff, sizeof(data->mac_stats)); memset(&data->ctrl_stats, 0xff, sizeof(data->mac_stats)); -- cgit v1.2.3