diff options
author | Stijn Tintel <stijn@linux-ipv6.be> | 2021-09-30 18:36:23 +0300 |
---|---|---|
committer | Stijn Tintel <stijn@linux-ipv6.be> | 2021-10-05 23:30:48 +0300 |
commit | 6f787b62d0a206db36540421b80ec5530b49bde2 (patch) | |
tree | 696a388f35bf8787bc1688c93cd62131b13fa47d /target/linux/bcm27xx/bcm2708 | |
parent | 297cb8c147fe66503c3772fdf46caa01ee2fb161 (diff) | |
download | openwrt-6f787b62d0a206db36540421b80ec5530b49bde2.tar.gz openwrt-6f787b62d0a206db36540421b80ec5530b49bde2.tar.bz2 openwrt-6f787b62d0a206db36540421b80ec5530b49bde2.zip |
bcm27xx: add SND_SOC_AD193X_{I2C,SPI} symbols
When building an image for the bcm27xx target, some combinations of
config options will fail to build due the SND_SOC_AD193X_I2C and
SND_SOC_AD193X_SPI kernel config symbols being missing.
The problem only occurs on bcm27xx as the target contains a patch that
modifies the Kconfig file containing the symbols; in the vanilla kernel,
there is no string after the tristate keyword so the symbol is not
exposed.
The _I2C symbol depends on I2C, which is enabled in the kernel configs
of all bcm27xx subtargets.
The _SPI symbol depends on SPI_MASTER, which is exposed by either
kmod-mmc-spi, kmod-spi-bitbang, kmod-spi-dev, kmod-spi-bcm2835 or
kmod-spi-bcm2835-aux.
Both symbols are defined in the sound/soc/codecs directory, which is
only included when SND_SOC is enabled, so this problem doesn't occur
when kmod-sound-soc-core is not enabled. As the
kmod-sound-soc-bcm2835-i2s package disables the SND_SOC_AD193X_SPI
symbol, it also doesn't occur when kmod-sound-soc-bcm2835-i2s is
enabled.
As there are several possible config combinations that do exhibit this
problem, it is best to solve it by adding the missing symbols to the
subtarget kernel configs. By doing this we can remove them from the
kmod-sound-soc-bcm2835-i2s package.
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'target/linux/bcm27xx/bcm2708')
-rw-r--r-- | target/linux/bcm27xx/bcm2708/config-5.10 | 2 | ||||
-rw-r--r-- | target/linux/bcm27xx/bcm2708/config-5.4 | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/target/linux/bcm27xx/bcm2708/config-5.10 b/target/linux/bcm27xx/bcm2708/config-5.10 index 094765abdc..12567abb24 100644 --- a/target/linux/bcm27xx/bcm2708/config-5.10 +++ b/target/linux/bcm27xx/bcm2708/config-5.10 @@ -321,6 +321,8 @@ CONFIG_SERIAL_MCTRL_GPIO=y CONFIG_SERIAL_OF_PLATFORM=y CONFIG_SG_POOL=y CONFIG_SMSC_PHY=y +# CONFIG_SND_SOC_AD193X_I2C is not set +# CONFIG_SND_SOC_AD193X_SPI is not set CONFIG_SPARSE_IRQ=y CONFIG_SRCU=y # CONFIG_STRIP_ASM_SYMS is not set diff --git a/target/linux/bcm27xx/bcm2708/config-5.4 b/target/linux/bcm27xx/bcm2708/config-5.4 index ef71076497..42203d2587 100644 --- a/target/linux/bcm27xx/bcm2708/config-5.4 +++ b/target/linux/bcm27xx/bcm2708/config-5.4 @@ -309,6 +309,8 @@ CONFIG_SERIAL_DEV_BUS=y CONFIG_SERIAL_MCTRL_GPIO=y CONFIG_SERIAL_OF_PLATFORM=y CONFIG_SG_POOL=y +# CONFIG_SND_SOC_AD193X_I2C is not set +# CONFIG_SND_SOC_AD193X_SPI is not set CONFIG_SPARSE_IRQ=y CONFIG_SRCU=y # CONFIG_STRIP_ASM_SYMS is not set |