diff options
| author | Myles Watson <mylesgw@gmail.com> | 2009-01-07 18:37:21 +0000 |
|---|---|---|
| committer | Myles Watson <mylesgw@gmail.com> | 2009-01-07 18:37:21 +0000 |
| commit | f1ad184bb70bcb132383431bdfe5dca4683695a3 (patch) | |
| tree | 19c504c75fa5aeed7b660ff8ff6784b36bc0698c | |
| parent | 13765fd116bd3fcad0508b45dbd4ed26a5a1716f (diff) | |
| download | coreboot-f1ad184bb70bcb132383431bdfe5dca4683695a3.tar.gz coreboot-f1ad184bb70bcb132383431bdfe5dca4683695a3.tar.bz2 coreboot-f1ad184bb70bcb132383431bdfe5dca4683695a3.zip | |
This trivial patch adds the warnings Peter and Ron requested to the ck804 code.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://coreboot.org/repository/coreboot-v3@1104 f3766cd6-281f-0410-b1cd-43a5c92072e9
| -rw-r--r-- | southbridge/nvidia/ck804/ck804_nic.c | 2 | ||||
| -rw-r--r-- | southbridge/nvidia/ck804/lpc.c | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/southbridge/nvidia/ck804/ck804_nic.c b/southbridge/nvidia/ck804/ck804_nic.c index 4b6b6804d1ea..a5bc5ddac50e 100644 --- a/southbridge/nvidia/ck804/ck804_nic.c +++ b/southbridge/nvidia/ck804/ck804_nic.c @@ -89,6 +89,8 @@ static void nic_init(struct device *dev) } } +#warning This should be fixed. Can we use a LAR file for the MAC? + /* If that is invalid we will read that from romstrap. */ if (!eeprom_valid) { unsigned long mac_pos; diff --git a/southbridge/nvidia/ck804/lpc.c b/southbridge/nvidia/ck804/lpc.c index f7d962c9fe83..79a41f1a1ff1 100644 --- a/southbridge/nvidia/ck804/lpc.c +++ b/southbridge/nvidia/ck804/lpc.c @@ -124,6 +124,8 @@ static void setup_ioapic(unsigned long ioapic_base) #define SLOW_CPU_OFF 0 #define SLOW_CPU__ON 1 +#warning Power on after fail should be a CMOS option. + #ifndef MAINBOARD_POWER_ON_AFTER_POWER_FAIL #define MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON #endif |