diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2018-04-10 13:42:03 +0200 |
|---|---|---|
| committer | Arthur Heymans <arthur@aheymans.xyz> | 2018-12-03 10:20:17 +0000 |
| commit | 0f8436cc91291c29d767489c1f5e92850d198519 (patch) | |
| tree | 3c0c53410300193976d41eaa1e327eb0b36ec1e4 | |
| parent | de6bda63d9890ac88a01368314fcf0802a694cf4 (diff) | |
| download | coreboot-0f8436cc91291c29d767489c1f5e92850d198519.tar.gz coreboot-0f8436cc91291c29d767489c1f5e92850d198519.tar.bz2 coreboot-0f8436cc91291c29d767489c1f5e92850d198519.zip | |
sb/intel/i82801gx: Clean up unneeded smi setup code
All i82801gx targets now use SMM_TSEG.
Change-Id: Ib4e6974088a685290ed1dddf5228a99918744124
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/25599
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/cpu/x86/smm/smmrelocate.S | 4 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801gx/Makefile.inc | 4 |
2 files changed, 1 insertions, 7 deletions
diff --git a/src/cpu/x86/smm/smmrelocate.S b/src/cpu/x86/smm/smmrelocate.S index bd12581a765d..fa49def1ad51 100644 --- a/src/cpu/x86/smm/smmrelocate.S +++ b/src/cpu/x86/smm/smmrelocate.S @@ -21,9 +21,7 @@ // can it be cleaned up so this include is not required? // It's needed right now because we get our DEFAULT_PMBASE from // here. -#if IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX) -#include <southbridge/intel/i82801gx/i82801gx.h> -#elif IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801DX) +#if IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801DX) #include <southbridge/intel/i82801dx/i82801dx.h> #elif IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801IX) #include <southbridge/intel/i82801ix/i82801ix.h> diff --git a/src/southbridge/intel/i82801gx/Makefile.inc b/src/southbridge/intel/i82801gx/Makefile.inc index 606afda3fe6f..290794b08d1a 100644 --- a/src/southbridge/intel/i82801gx/Makefile.inc +++ b/src/southbridge/intel/i82801gx/Makefile.inc @@ -32,10 +32,6 @@ ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c ramstage-y += watchdog.c -ifneq ($(CONFIG_SMM_TSEG),y) -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c -ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S -endif smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c romstage-y += early_smbus.c early_lpc.c |