diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2022-12-03 08:25:18 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2022-12-23 03:09:20 +0000 |
| commit | 100f92c54f2f199e98d817bd16ae7530e8ad719c (patch) | |
| tree | 0111fb5b05c20fc1765e644026ec5e8dd17bd504 | |
| parent | 4c61294498254c0cc07608632228f84b2e555a06 (diff) | |
| download | coreboot-100f92c54f2f199e98d817bd16ae7530e8ad719c.tar.gz coreboot-100f92c54f2f199e98d817bd16ae7530e8ad719c.tar.bz2 coreboot-100f92c54f2f199e98d817bd16ae7530e8ad719c.zip | |
mb,x86/smm: Disable unused IO traps
Only IO trap #3 for lenovo/x60,t60 and getac/p470 have implemented
the IO trap handler.
Change-Id: Ibadce174f673e88380f4b6745fd9ed8b73177a13
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70367
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/apple/macbook21/early_init.c | 6 | ||||
| -rw-r--r-- | src/mainboard/getac/p470/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/lenovo/t60/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/lenovo/x60/early_init.c | 3 | ||||
| -rw-r--r-- | src/mainboard/roda/rk886ex/early_init.c | 10 | ||||
| -rw-r--r-- | src/southbridge/intel/ibexpeak/lpc.c | 4 |
6 files changed, 0 insertions, 29 deletions
diff --git a/src/mainboard/apple/macbook21/early_init.c b/src/mainboard/apple/macbook21/early_init.c index 42e7d77cf7ed..c0a57cc8fc22 100644 --- a/src/mainboard/apple/macbook21/early_init.c +++ b/src/mainboard/apple/macbook21/early_init.c @@ -23,10 +23,4 @@ void mainboard_late_rcba_config(void) /* Disable unused devices */ RCBA32(FD) |= FD_INTLAN; - - /* Set up I/O Trap #0 for 0xfe00 (SMIC) */ - - /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */ - RCBA32(0x1e9c) = 0x000200f0; - RCBA32(0x1e98) = 0x000c0801; } diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c index c28d6021156b..1f206acd3a5e 100644 --- a/src/mainboard/getac/p470/early_init.c +++ b/src/mainboard/getac/p470/early_init.c @@ -122,9 +122,6 @@ void mainboard_late_rcba_config(void) RCBA32(FD) |= FD_INTLAN; /* This should probably go into the ACPI enable trap */ - /* Set up I/O Trap #0 for 0xfe00 (SMIC) */ - RCBA32(0x1e84) = 0x00020001; - RCBA32(0x1e80) = 0x0000fe01; /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */ RCBA32(0x1e9c) = 0x000200f0; diff --git a/src/mainboard/lenovo/t60/early_init.c b/src/mainboard/lenovo/t60/early_init.c index 0a1ae53b72b8..3e3c2692e90a 100644 --- a/src/mainboard/lenovo/t60/early_init.c +++ b/src/mainboard/lenovo/t60/early_init.c @@ -73,9 +73,6 @@ void mainboard_late_rcba_config(void) /* Disable unused devices */ RCBA32(FD) |= FD_INTLAN; - /* Set up I/O Trap #0 for 0xfe00 (SMIC) */ - RCBA64(IOTR0) = 0x000200010000fe01ULL; - /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */ RCBA64(IOTR3) = 0x000200f0000c0801ULL; } diff --git a/src/mainboard/lenovo/x60/early_init.c b/src/mainboard/lenovo/x60/early_init.c index 3add1952cd00..1c58a3a2c419 100644 --- a/src/mainboard/lenovo/x60/early_init.c +++ b/src/mainboard/lenovo/x60/early_init.c @@ -72,9 +72,6 @@ void mainboard_late_rcba_config(void) /* Disable unused devices */ RCBA32(FD) |= FD_INTLAN; - /* Set up I/O Trap #0 for 0xfe00 (SMIC) */ - RCBA64(IOTR0) = 0x000200010000fe01ULL; - /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */ RCBA64(IOTR3) = 0x000200f0000c0801ULL; } diff --git a/src/mainboard/roda/rk886ex/early_init.c b/src/mainboard/roda/rk886ex/early_init.c index ddea82f46e4f..9fdbeb64af5e 100644 --- a/src/mainboard/roda/rk886ex/early_init.c +++ b/src/mainboard/roda/rk886ex/early_init.c @@ -77,16 +77,6 @@ void mainboard_late_rcba_config(void) /* Disable unused devices */ RCBA32(FD) |= FD_INTLAN; - - /* This should probably go into the ACPI OS Init trap */ - - /* Set up I/O Trap #0 for 0xfe00 (SMIC) */ - RCBA32(0x1e84) = 0x00020001; - RCBA32(0x1e80) = 0x0000fe01; - - /* Set up I/O Trap #3 for 0x800-0x80c (Trap) */ - RCBA32(0x1e9c) = 0x000200f0; - RCBA32(0x1e98) = 0x000c0801; } static void init_artec_dongle(void) diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index f0d0ac92edc2..7d85883bd95e 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -265,10 +265,6 @@ static void mobile5_pm_init(struct device *dev) (void)RCBA32(0x1d44); RCBA32(0x1d48) = 0x00030000; (void)RCBA32(0x1d48); - RCBA32(0x1e80) = 0x000c0801; - (void)RCBA32(0x1e80); - RCBA32(0x1e84) = 0x000200f0; - (void)RCBA32(0x1e84); const u32 rcba2010[] = { /* 2010: */ 0x00188200, 0x14000016, 0xbc4abcb5, 0x00000000, |