diff options
| author | Ren Kuo <ren.kuo@quanta.corp-partner.google.com> | 2021-08-02 14:31:35 +0800 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2021-08-04 15:16:09 +0000 |
| commit | 163dfe68f68890b4a0c3283c215d159bf90ea1bb (patch) | |
| tree | a8d5139a6b292253f27039c59f9863ac6e49483d | |
| parent | 9fe70ed1975cce3fd839a975c71e6c6bf0013d98 (diff) | |
| download | coreboot-163dfe68f68890b4a0c3283c215d159bf90ea1bb.tar.gz coreboot-163dfe68f68890b4a0c3283c215d159bf90ea1bb.tar.bz2 coreboot-163dfe68f68890b4a0c3283c215d159bf90ea1bb.zip | |
mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
The all shipped magolor and maglia has SSFC= 0x840.
The value is defined as 5M MIPI camera.But the value:0x840 will
conflict with the updated touchscreen field.
It will cause some touchscreen no function if make auto-update new
firmware.The CL would correct the field error.
The original fields:
CAMERA_WFC 38 40
TS_SOURCE 41 44
Correct fields:
MIPI Cam
CAMERA_WFC 38 40
CAMERA_UFC 41 42
CAMERA_VCM 43 44
Touch-screen
TS_SOURCE 45 48
The SSFC value of Magolor:
CAMERA_OVTI5675 5M AF (SSFC = 0x840)
CAMERA_OVTI8856 8M AF (SSFC = 0x880)
BUG=b:194639170
TEST=Build firmware and verify on camera and touch-screen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56685
Reviewed-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/dedede/variants/magolor/overridetree.cb | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index ef0dd2c3d6e4..60e82cb3b170 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -1,10 +1,17 @@ fw_config field CAMERA_WFC 38 40 - option CAMERA_NONE 0 + option CAMERA_UNPROVISIONED 0 option CAMERA_OVTI5675 1 option CAMERA_OVTI8856 2 end - field TS_SOURCE 41 44 + field CAMERA_UFC 41 42 + option CAMERA_UFC_UNPROVISIONED 0 + end + field CAMERA_VCM 43 44 + option CAMERA_VCM_UNPROVISIONED 0 + option CAMERA_VCM0 1 + end + field TS_SOURCE 45 48 option TS_UNPROVISIONED 0 option TS_ELAN_6915 1 option TS_ELAN_6918 2 @@ -324,7 +331,7 @@ chip soc/intel/jasperlake register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" device i2c 36 on - probe CAMERA_WFC CAMERA_NONE + probe CAMERA_WFC CAMERA_UNPROVISIONED probe CAMERA_WFC CAMERA_OVTI5675 end end @@ -381,8 +388,10 @@ chip soc/intel/jasperlake register "pr0" = ""\\_SB.PCI0.I2C3.CAM0.PRIC"" register "vcm_compat" = ""dongwoon,dw9714"" - device i2c 0C on end - + device i2c 0C on + probe CAMERA_VCM CAMERA_VCM_UNPROVISIONED + probe CAMERA_VCM CAMERA_VCM0 + end end chip drivers/intel/mipi_camera register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" |