summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKeith Short <keithshort@chromium.org>2019-05-16 11:46:27 -0600
committerDuncan Laurie <dlaurie@chromium.org>2019-05-22 16:52:48 +0000
commit1835bf0fd4b77ab3eae1fb085be1667d13ed3144 (patch)
tree3398098301f8ac691c616a98ec08c070dbaa8054
parent7006458777483291abfca790beb48f201ba74c37 (diff)
downloadcoreboot-1835bf0fd4b77ab3eae1fb085be1667d13ed3144.tar.gz
coreboot-1835bf0fd4b77ab3eae1fb085be1667d13ed3144.tar.bz2
coreboot-1835bf0fd4b77ab3eae1fb085be1667d13ed3144.zip
post_code: add post code for critical CBFS failures
Add a new post code POST_INVALID_CBFS, used when coreboot fails to locate or validate a resource that is stored in CBFS. BUG=b:124401932 BRANCH=sarien TEST=build coreboot for sarien and arcada platforms Change-Id: If1c8b92889040f9acd6250f847db02626809a987 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32771 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
-rw-r--r--Documentation/POSTCODES1
-rw-r--r--src/include/console/post_codes.h7
-rw-r--r--src/soc/intel/quark/romstage/fsp2_0.c3
3 files changed, 10 insertions, 1 deletions
diff --git a/Documentation/POSTCODES b/Documentation/POSTCODES
index 2340fac04921..162e863fede0 100644
--- a/Documentation/POSTCODES
+++ b/Documentation/POSTCODES
@@ -17,6 +17,7 @@ This is an (incomplete) list of POST codes emitted by coreboot v4.
0x88 Devices have been configured
0x89 Devices have been enabled
0xe0 Boot media (e.g. SPI ROM) is corrupt
+0xe1 Resource stored within CBFS is corrupt
0xf8 Entry into elf boot
0xf3 Jumping to payload
diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h
index 775f78d6039e..7bd1ee0798d3 100644
--- a/src/include/console/post_codes.h
+++ b/src/include/console/post_codes.h
@@ -326,6 +326,13 @@
#define POST_INVALID_ROM 0xe0
/**
+ * \brief Invalid or corrupt CBFS
+ *
+ * Set if firmware failed to find or validate a resource that is stored in CBFS.
+ */
+#define POST_INVALID_CBFS 0xe1
+
+/**
* \brief TPM failure
*
* An error with the TPM, either unexepcted state or communications failure.
diff --git a/src/soc/intel/quark/romstage/fsp2_0.c b/src/soc/intel/quark/romstage/fsp2_0.c
index 2ec16c9f3418..e4abcc034ad2 100644
--- a/src/soc/intel/quark/romstage/fsp2_0.c
+++ b/src/soc/intel/quark/romstage/fsp2_0.c
@@ -116,7 +116,8 @@ void platform_fsp_memory_init_params_cb(FSPM_UPD *fspm_upd, uint32_t version)
/* Locate the RMU data file in flash */
rmu_data = locate_rmu_file(&rmu_data_len);
if (!rmu_data)
- die("Microcode file (rmu.bin) not found.");
+ die_with_post_code(POST_INVALID_CBFS,
+ "Microcode file (rmu.bin) not found.");
/* Locate the configuration data from devicetree.cb */
dev = pcidev_path_on_root(LPC_DEV_FUNC);