summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2017-12-27 20:52:04 +0100
committerFelix Held <felix-coreboot@felixheld.de>2018-01-06 10:00:25 +0000
commit1a14375a8830ec1521fca1eec4047ee14cc25d15 (patch)
tree5b4d334834c73908c7c29b1a140651e1c696b857
parentb331923c69fb15ca47bb89b1a08564532b83af22 (diff)
downloadcoreboot-1a14375a8830ec1521fca1eec4047ee14cc25d15.tar.gz
coreboot-1a14375a8830ec1521fca1eec4047ee14cc25d15.tar.bz2
coreboot-1a14375a8830ec1521fca1eec4047ee14cc25d15.zip
superio/ite: add missing pnp_conf_mode fields in ops struct
This fixes the bug that the LDNs on the affected SIO chips didn't get configured, since the config mode wasn't entered. Change-Id: Ic468847571e164e4e1280428f08fc067b724464e Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/23004 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
-rw-r--r--src/superio/ite/it8671f/superio.c2
-rw-r--r--src/superio/ite/it8718f/superio.c2
-rw-r--r--src/superio/ite/it8721f/superio.c2
3 files changed, 6 insertions, 0 deletions
diff --git a/src/superio/ite/it8671f/superio.c b/src/superio/ite/it8671f/superio.c
index f69a06c45f31..4fa24de4b5e2 100644
--- a/src/superio/ite/it8671f/superio.c
+++ b/src/superio/ite/it8671f/superio.c
@@ -18,6 +18,7 @@
#include <device/pnp.h>
#include <pc80/keyboard.h>
#include <stdlib.h>
+#include <superio/conf_mode.h>
#include "it8671f.h"
static void init(struct device *dev)
@@ -45,6 +46,7 @@ static struct device_operations ops = {
.enable_resources = pnp_enable_resources,
.enable = pnp_enable,
.init = init,
+ .ops_pnp_mode = &pnp_conf_mode_870155_aa,
};
/* TODO: FDC, PP, KBCM. */
diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c
index b4ac679ff604..ca2fedb6d3f5 100644
--- a/src/superio/ite/it8718f/superio.c
+++ b/src/superio/ite/it8718f/superio.c
@@ -19,6 +19,7 @@
#include <pc80/keyboard.h>
#include <stdlib.h>
#include <superio/ite/common/env_ctrl.h>
+#include <superio/conf_mode.h>
#include "it8718f.h"
#include "chip.h"
@@ -59,6 +60,7 @@ static struct device_operations ops = {
.enable_resources = pnp_enable_resources,
.enable = pnp_enable,
.init = init,
+ .ops_pnp_mode = &pnp_conf_mode_870155_aa,
};
/* TODO: IR. */
diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c
index 98386595054d..cd01f30c7264 100644
--- a/src/superio/ite/it8721f/superio.c
+++ b/src/superio/ite/it8721f/superio.c
@@ -19,6 +19,7 @@
#include <device/pnp.h>
#include <pc80/keyboard.h>
#include <stdlib.h>
+#include <superio/conf_mode.h>
#include "it8721f.h"
static void init(struct device *dev)
@@ -50,6 +51,7 @@ static struct device_operations ops = {
.enable_resources = pnp_enable_resources,
.enable = pnp_enable,
.init = init,
+ .ops_pnp_mode = &pnp_conf_mode_870155_aa,
};
/* TODO: FDC, PP, EC, KBCM, IR. */