diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-01-06 14:30:19 +0100 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-18 04:38:56 +0000 |
| commit | 20a95339461699b77e6088a80cf9edf716b12056 (patch) | |
| tree | 86bd344172fdde3189b8028a3dfa3eec6dfa01d3 | |
| parent | a506451d9fbf8ab520295934076a328f734bf401 (diff) | |
| download | coreboot-20a95339461699b77e6088a80cf9edf716b12056.tar.gz coreboot-20a95339461699b77e6088a80cf9edf716b12056.tar.bz2 coreboot-20a95339461699b77e6088a80cf9edf716b12056.zip | |
sb/intel/bd82x6x: Rework PCH ID cache
Work around a romstage restriction. Globals (or static variables) cannot
be initialized to a non-zero value because there's no data section. Note
that the revision ID for stepping A0 is zero, so `pch_silicon_revision`
will no longer use the cached value for this PCH stepping. Since it is a
pre-production stepping, it is most likely not used anywhere anymore.
Change-Id: I07663d151cbc2d2ed7e4813bf870de52848753fd
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49168
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
| -rw-r--r-- | src/southbridge/intel/bd82x6x/common.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/southbridge/intel/bd82x6x/common.c b/src/southbridge/intel/bd82x6x/common.c index 7163d3edc7bd..63d2fb22e0a8 100644 --- a/src/southbridge/intel/bd82x6x/common.c +++ b/src/southbridge/intel/bd82x6x/common.c @@ -14,9 +14,9 @@ int pch_silicon_revision(void) { - static int pch_revision_id = -1; + static int pch_revision_id = 0; - if (pch_revision_id < 0) + if (!pch_revision_id) pch_revision_id = pci_read_config8(PCH_LPC_DEV, PCI_REVISION_ID); return pch_revision_id; @@ -24,9 +24,9 @@ int pch_silicon_revision(void) int pch_silicon_type(void) { - static int pch_type = -1; + static int pch_type = 0; - if (pch_type < 0) + if (!pch_type) pch_type = pci_read_config8(PCH_LPC_DEV, PCI_DEVICE_ID + 1); return pch_type; |