diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2014-08-04 15:40:50 -0500 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-03-25 22:31:52 +0100 |
| commit | 2f3a7fb45dcc7d83f8888874924dd8d6ab46afc6 (patch) | |
| tree | 25fe35b64ada0be5e97cc501a8325eb30d478bfd | |
| parent | 9e76090fe999a23d1952d894b5ef0e9794bd71e0 (diff) | |
| download | coreboot-2f3a7fb45dcc7d83f8888874924dd8d6ab46afc6.tar.gz coreboot-2f3a7fb45dcc7d83f8888874924dd8d6ab46afc6.tar.bz2 coreboot-2f3a7fb45dcc7d83f8888874924dd8d6ab46afc6.zip | |
tegra: correct gpio_index_to_port() calculation
The gpio_index_to_port() incorrectly was dividing by
GPIO_PORTS_PER_BANK on a value including the bit number. After
masking off the BANK offset just divide by the number of gpios
in a port to get the port offset.
BUG=chrome-os-partner:29981
BRANCH=None
TEST=Built and ran through to depthcharge. Printed bank, port, and
bit numbers for validation.
Change-Id: I3fbbb90f369bace90e787148a58795b7b1b40c1b
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 97e1f830b4a8e948673433bfa6d81586204b6ee2
Original-Change-Id: I8bb50e922c9fd7c0a1c247ba95394f6deb9f1533
Original-Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/210909
Original-Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: http://review.coreboot.org/8908
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/soc/nvidia/tegra/gpio.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/nvidia/tegra/gpio.h b/src/soc/nvidia/tegra/gpio.h index da8a4dad71db..2ad3ab3e5fe4 100644 --- a/src/soc/nvidia/tegra/gpio.h +++ b/src/soc/nvidia/tegra/gpio.h @@ -90,7 +90,7 @@ static inline int gpio_index_to_bank(int index) static inline int gpio_index_to_port(int index) { - return (index % GPIO_GPIOS_PER_BANK) / GPIO_PORTS_PER_BANK; + return (index % GPIO_GPIOS_PER_BANK) / GPIO_GPIOS_PER_PORT; } static inline int gpio_to_bit(int index) |