diff options
| author | Tarun Tuli <taruntuli@google.com> | 2023-05-09 13:00:26 +0000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-05-11 16:48:44 +0000 |
| commit | 3e304e5257d30920101e82510a17abe20b581d68 (patch) | |
| tree | 6abec9cd97befbbbc7e4158775a0f97cf784587d | |
| parent | 7ad8b0987ac6f3438b209ce2c6d3bd16a5c93f21 (diff) | |
| download | coreboot-3e304e5257d30920101e82510a17abe20b581d68.tar.gz coreboot-3e304e5257d30920101e82510a17abe20b581d68.tar.bz2 coreboot-3e304e5257d30920101e82510a17abe20b581d68.zip | |
mb/google/brya/variant/hades: Reduce PEXVDD shutoff delay for Hades
For the sequenced controlled shutdown path, there's a 10ms delay
after the PEXVDD rail is disabled to permit discharge needed on
Agah/Proxima.
This can be dropped to 3ms for Hades designs Proto0 and forward.
Once Agah board is dropped, "if CONFIG" can be cleaned up/removed.
BUG=b:271167335
TEST=builds
Signed-off-by: Tarun Tuli <taruntuli@google.com>
Change-Id: I8a0d62ec76caff861adce2d6c0ba2d4e4064affa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75051
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/brya/acpi/power.asl | 8 | ||||
| -rw-r--r-- | src/mainboard/google/brya/variants/hades/variant.c | 2 |
2 files changed, 9 insertions, 1 deletions
diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index 186b10977f69..171b4061789f 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -131,7 +131,11 @@ Method (GC6I, 0, Serialized) /* Ramp down PEXVDD */ CTXS (GPIO_PEXVDD_PWR_EN) GPPL (GPIO_PEXVDD_PG, 0, 20) +#if CONFIG(BOARD_GOOGLE_AGAH) Sleep (10) +#else + Sleep (3) +#endif /* Deassert EN_PPVAR_GPU_NVVDD */ CTXS (GPIO_NVVDD_PWR_EN) @@ -272,7 +276,11 @@ Method (PGOF, 0, Serialized) /* Ramp down PEXVDD and let rail discharge to <10% */ CTXS (GPIO_PEXVDD_PWR_EN) GPPL (GPIO_PEXVDD_PG, 0, 20) +#if CONFIG(BOARD_GOOGLE_AGAH) Sleep (10) +#else + Sleep (3) +#endif /* Ramp down NVVDD and let rail discharge to <10% */ CTXS (GPIO_NVVDD_PWR_EN) diff --git a/src/mainboard/google/brya/variants/hades/variant.c b/src/mainboard/google/brya/variants/hades/variant.c index 38ff79371e3e..5cdfabbb7cb3 100644 --- a/src/mainboard/google/brya/variants/hades/variant.c +++ b/src/mainboard/google/brya/variants/hades/variant.c @@ -61,7 +61,7 @@ static struct power_rail_sequence gpu_on_seq[] = { /* In GCOFF entry order (i.e., power-off order) */ static struct power_rail_sequence gpu_off_seq[] = { { "FBVDD", FBVDD_PWR_EN, false, FBVDD_PG, 0,}, - { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 10,}, + { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 3,}, { "NVVDD+MSVDD", NVVDD_PWR_EN, false, NVVDD_PG, 2,}, { "GPU 3.3V", GPU_3V3_PWR_EN, false, GPU_3V3_PG, 4,}, { "GPU 1.8V", GPU_1V8_PWR_EN, false, GPU_1V8_PG, 0,}, |