diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2022-05-10 18:25:06 +0200 |
|---|---|---|
| committer | Arthur Heymans <arthur@aheymans.xyz> | 2022-05-13 11:00:59 +0000 |
| commit | 522c92ed35dd8f7f145aabbe7b3e6ddc4992b4f9 (patch) | |
| tree | 8f61d16e29ce6a6d638616bb71fb66c095a0c998 | |
| parent | 6f9805e0c7aaba7c5ea3ae51486f4d8dec570fc5 (diff) | |
| download | coreboot-522c92ed35dd8f7f145aabbe7b3e6ddc4992b4f9.tar.gz coreboot-522c92ed35dd8f7f145aabbe7b3e6ddc4992b4f9.tar.bz2 coreboot-522c92ed35dd8f7f145aabbe7b3e6ddc4992b4f9.zip | |
mb/google/glados: Fix unused variable
Commit f89cb241eec introduced a regression where the RcompTarget was
not updated according to the SPD.
Change-Id: I07715224b11937604b107e370d957745b245ddd9
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64239
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/glados/variants/lars/variant.c | 2 | ||||
| -rw-r--r-- | src/mainboard/google/glados/variants/sentry/variant.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/glados/variants/lars/variant.c b/src/mainboard/google/glados/variants/lars/variant.c index 8e3856ad30b8..a4e42b170f5e 100644 --- a/src/mainboard/google/glados/variants/lars/variant.c +++ b/src/mainboard/google/glados/variants/lars/variant.c @@ -51,7 +51,7 @@ void variant_memory_init_params(FSPM_UPD *mupd, const int spd_index) memcpy(mem_cfg->DqsMapCpu2DramCh0, dqs_map[0], sizeof(mem_cfg->DqsMapCpu2DramCh0)); memcpy(mem_cfg->DqsMapCpu2DramCh1, dqs_map[1], sizeof(mem_cfg->DqsMapCpu2DramCh1)); memcpy(mem_cfg->RcompResistor, RcompResistor, sizeof(mem_cfg->RcompResistor)); - memcpy(mem_cfg->RcompTarget, RcompTarget, sizeof(mem_cfg->RcompTarget)); + memcpy(mem_cfg->RcompTarget, targeted_rcomp, sizeof(mem_cfg->RcompTarget)); } int is_dual_channel(const int spd_index) diff --git a/src/mainboard/google/glados/variants/sentry/variant.c b/src/mainboard/google/glados/variants/sentry/variant.c index 6a788422719d..941115b2272c 100644 --- a/src/mainboard/google/glados/variants/sentry/variant.c +++ b/src/mainboard/google/glados/variants/sentry/variant.c @@ -44,5 +44,5 @@ void variant_memory_init_params(FSPM_UPD *mupd, const int spd_index) memcpy(mem_cfg->DqsMapCpu2DramCh0, dqs_map[0], sizeof(mem_cfg->DqsMapCpu2DramCh0)); memcpy(mem_cfg->DqsMapCpu2DramCh1, dqs_map[1], sizeof(mem_cfg->DqsMapCpu2DramCh1)); memcpy(mem_cfg->RcompResistor, RcompResistor, sizeof(mem_cfg->RcompResistor)); - memcpy(mem_cfg->RcompTarget, RcompTarget, sizeof(mem_cfg->RcompTarget)); + memcpy(mem_cfg->RcompTarget, targeted_rcomp, sizeof(mem_cfg->RcompTarget)); } |