diff options
| author | Subrata Banik <subrata.banik@intel.com> | 2018-12-10 14:19:35 +0530 |
|---|---|---|
| committer | Subrata Banik <subrata.banik@intel.com> | 2018-12-15 04:20:10 +0000 |
| commit | 78c919bdc87bf4ad7fd39b90b9b0cd3ee33ec494 (patch) | |
| tree | ee437658e51db5a519abaff905c41f82781c9ae1 | |
| parent | 5d7f5bc973f4aac3e2833baba7e6e386c602f5b4 (diff) | |
| download | coreboot-78c919bdc87bf4ad7fd39b90b9b0cd3ee33ec494.tar.gz coreboot-78c919bdc87bf4ad7fd39b90b9b0cd3ee33ec494.tar.bz2 coreboot-78c919bdc87bf4ad7fd39b90b9b0cd3ee33ec494.zip | |
mb/{intel,google}/{icelake_rvp,dragonegg}: make use of cpu_get_cpuid() helper function
This patch replaces cpuid(1) references from icelake mainboard
with x86 cpu common code library functions cpu_get_cpuid().
- cpu_get_cpuid() -> to get processor id (from cpuid.eax)
Change-Id: Ia12d95d911dd6ee60a3a35937264fef668ad9e35
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/30124
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aamir Bohra <aamir.bohra@intel.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
| -rw-r--r-- | src/mainboard/google/dragonegg/variants/baseboard/memory.c | 15 | ||||
| -rw-r--r-- | src/mainboard/intel/icelake_rvp/spd/spd_util.c | 15 |
2 files changed, 2 insertions, 28 deletions
diff --git a/src/mainboard/google/dragonegg/variants/baseboard/memory.c b/src/mainboard/google/dragonegg/variants/baseboard/memory.c index c7d579b1a9e0..3c458e800e6c 100644 --- a/src/mainboard/google/dragonegg/variants/baseboard/memory.c +++ b/src/mainboard/google/dragonegg/variants/baseboard/memory.c @@ -36,19 +36,6 @@ static const u8 dqs_map[][8] = { /* Rcomp resistor */ static const u16 rcomp_resistor[] = { 100, 100, 100 }; -/* - * get processor id using cpuid eax=1 - * return value will be in EAX register - */ -static uint32_t get_cpuid(void) -{ - struct cpuid_result cpuidr; - - cpuidr = cpuid(1); - - return cpuidr.eax; -} - void __weak variant_memory_params(struct lpddr4_config *mem_config) { /* Rcomp target */ @@ -61,7 +48,7 @@ void __weak variant_memory_params(struct lpddr4_config *mem_config) mem_config->dqs_map_size = sizeof(dqs_map); mem_config->rcomp_resistor = rcomp_resistor; mem_config->rcomp_resistor_size = sizeof(rcomp_resistor); - if (get_cpuid() == CPUID_ICELAKE_A0) { + if (cpu_get_cpuid() == CPUID_ICELAKE_A0) { mem_config->rcomp_target = rcomp_target_es0; mem_config->rcomp_target_size = sizeof(rcomp_target_es0); } else { diff --git a/src/mainboard/intel/icelake_rvp/spd/spd_util.c b/src/mainboard/intel/icelake_rvp/spd/spd_util.c index 63b39fd3f4be..6b733642cdc5 100644 --- a/src/mainboard/intel/icelake_rvp/spd/spd_util.c +++ b/src/mainboard/intel/icelake_rvp/spd/spd_util.c @@ -111,19 +111,6 @@ void mainboard_fill_rcomp_res_data(void *rcomp_ptr) memcpy(rcomp_ptr, RcompResistor, sizeof(RcompResistor)); } -/* - * get processor id using cpuid eax=1 - * return value will be in EAX register - */ -static uint32_t get_cpuid(void) -{ - struct cpuid_result cpuidr; - - cpuidr = cpuid(1); - - return cpuidr.eax; -} - void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr) { /* Rcomp target */ @@ -142,7 +129,7 @@ void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr) case icl_y_lpddr4: case icl_u_lpddr4: case icl_u_lpddr4_type_3: - if (get_cpuid() == CPUID_ICELAKE_A0) + if (cpu_get_cpuid() == CPUID_ICELAKE_A0) memcpy(rcomp_strength_ptr, RcompTarget_LPDDR4_Ax, sizeof(RcompTarget_LPDDR4_Ax)); else |