diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2024-02-14 13:51:01 +0100 |
|---|---|---|
| committer | Lean Sheng Tan <sheng.tan@9elements.com> | 2024-02-22 14:57:49 +0000 |
| commit | 836a6d80817aee758b31ed254bdedbdade9e1dde (patch) | |
| tree | 4db8e180177d1f5b9768462b8dbd7f7bfd7b1978 | |
| parent | 313b18abe5415ed31d1dd52344bd27e56278c9e7 (diff) | |
| download | coreboot-836a6d80817aee758b31ed254bdedbdade9e1dde.tar.gz coreboot-836a6d80817aee758b31ed254bdedbdade9e1dde.tar.bz2 coreboot-836a6d80817aee758b31ed254bdedbdade9e1dde.zip | |
soc/intel/xeon_sp: Align resources to 4K
The lower bit of the BAR might be used for something else,
like enable bits, so mask the lower 12 bits and align all
base address to 4K.
Confirmed that all BARs have a minimum alignment of 4K, so that
masking the lower bits doesn't change the reported address.
The alignment of the VTD BARs is:
- VTD_MMCFG_BASE_CSR 64 MiB
- VTD_MMIOL_CSR 1 MiB
- VTD_NCMEM_BASE_CSR 64 MiB
- VTD_TSEG_BASE_CSR 1 MiB
- VTD_BAR_CSR 4 KiB
Change-Id: I9a7b963c0074246616968dd15c147f4916297d59
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80548
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
| -rw-r--r-- | src/soc/intel/xeon_sp/include/soc/iomap.h | 4 | ||||
| -rw-r--r-- | src/soc/intel/xeon_sp/uncore.c | 1 |
2 files changed, 2 insertions, 3 deletions
diff --git a/src/soc/intel/xeon_sp/include/soc/iomap.h b/src/soc/intel/xeon_sp/include/soc/iomap.h index f348ab933035..ccc7e44d2388 100644 --- a/src/soc/intel/xeon_sp/include/soc/iomap.h +++ b/src/soc/intel/xeon_sp/include/soc/iomap.h @@ -9,9 +9,9 @@ .mask_bits = mask_bits_, .description = desc_, \ } -#define MAP_ENTRY_BASE_64(reg_, desc_) MAP_ENTRY(reg_, 1, 0, 0, desc_) +#define MAP_ENTRY_BASE_64(reg_, desc_) MAP_ENTRY(reg_, 1, 0, 12, desc_) #define MAP_ENTRY_LIMIT_64(reg_, mask_bits_, desc_) MAP_ENTRY(reg_, 1, 1, mask_bits_, desc_) -#define MAP_ENTRY_BASE_32(reg_, desc_) MAP_ENTRY(reg_, 0, 0, 0, desc_) +#define MAP_ENTRY_BASE_32(reg_, desc_) MAP_ENTRY(reg_, 0, 0, 12, desc_) #define MAP_ENTRY_LIMIT_32(reg_, mask_bits_, desc_) MAP_ENTRY(reg_, 0, 1, mask_bits_, desc_) // SPI BAR0 MMIO base address diff --git a/src/soc/intel/xeon_sp/uncore.c b/src/soc/intel/xeon_sp/uncore.c index 96855edd5a42..df2ffac09d4a 100644 --- a/src/soc/intel/xeon_sp/uncore.c +++ b/src/soc/intel/xeon_sp/uncore.c @@ -77,7 +77,6 @@ static void read_map_entry(struct device *dev, struct map_entry *entry, return; } - /* All registers are on a 1MiB granularity. */ mask = ((1ULL << entry->mask_bits) - 1); mask = ~mask; |