diff options
| author | Subrata Banik <subrata.banik@intel.com> | 2021-04-09 20:35:09 +0530 |
|---|---|---|
| committer | Subrata Banik <subrata.banik@intel.com> | 2021-04-10 12:00:33 +0000 |
| commit | 8cbe43b8d73ba02fc771f8ea00f7ec4ab2e37f5b (patch) | |
| tree | f247394eb42fd4dcb5da95bbe004a2e45aa4bfc5 | |
| parent | 7c25317093bfae2010e3cfb1981910d8592d8f70 (diff) | |
| download | coreboot-8cbe43b8d73ba02fc771f8ea00f7ec4ab2e37f5b.tar.gz coreboot-8cbe43b8d73ba02fc771f8ea00f7ec4ab2e37f5b.tar.bz2 coreboot-8cbe43b8d73ba02fc771f8ea00f7ec4ab2e37f5b.zip | |
soc/intel/alderlake: Skip D3Cold for TBT
Check TBT NVM FW Ready (INFR) bit to skip D3Cold for TBT when device
is in disconnected state.
Not adhering this recommendation is blocking the S0ix state transition.
BUG=b:183670327
TEST=S0ix state transition occurs with TBT disconnected.
Change-Id: Ib9b9ceee4393aeba37fdcb4e05d1b279a6ff72d2
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s@intel.com>
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51274
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
| -rw-r--r-- | src/soc/intel/alderlake/acpi/tcss.asl | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/soc/intel/alderlake/acpi/tcss.asl b/src/soc/intel/alderlake/acpi/tcss.asl index 1b13260bc6d2..30bca381145f 100644 --- a/src/soc/intel/alderlake/acpi/tcss.asl +++ b/src/soc/intel/alderlake/acpi/tcss.asl @@ -555,6 +555,9 @@ Scope (\_SB.PCI0) Printf("TDM0 does not exist.") } Else { If (\_SB.PCI0.TDM0.STAT == 1) { + If (\_SB.PCI0.TDM0.INFR != 1) { + Return + } /* DMA0 is not in D3Cold now. */ \_SB.PCI0.TDM0.D3CE() /* Enable DMA RTD3 */ @@ -610,6 +613,9 @@ Scope (\_SB.PCI0) Printf("TDM1 does not exist.") } Else { If (\_SB.PCI0.TDM1.STAT == 1) { + If (\_SB.PCI0.TDM1.INFR != 1) { + Return + } /* DMA1 is not in D3Cold now */ \_SB.PCI0.TDM1.D3CE() /* Enable DMA RTD3. */ |