summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico Huber <nico.huber@secunet.com>2021-06-24 12:58:52 +0000
committerNico Huber <nico.h@gmx.de>2021-07-28 13:46:05 +0000
commit8e0d1936a2b7d9cccaa4d46952061eec8b16e1b2 (patch)
tree2ee25412f218e81bbfef701927eec757919cde70
parentdf060bc362c060a72b9493a68d7dff8f48a7b6c6 (diff)
downloadcoreboot-8e0d1936a2b7d9cccaa4d46952061eec8b16e1b2.tar.gz
coreboot-8e0d1936a2b7d9cccaa4d46952061eec8b16e1b2.tar.bz2
coreboot-8e0d1936a2b7d9cccaa4d46952061eec8b16e1b2.zip
ec/roda/it8518/acpi: Don't hard-code GPE offset
The GPE offset of 16 is PCH specific. Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the same. Change-Id: I4ec38fc28d2436f84a090bb4ab38f20612cfd795 Signed-off-by: Nico Huber <nico.huber@secunet.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56080 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/ec/roda/it8518/acpi/ec.asl2
-rw-r--r--src/mainboard/roda/rv11/acpi/ec.asl2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl
index de121c622685..28f9c88eb68e 100644
--- a/src/ec/roda/it8518/acpi/ec.asl
+++ b/src/ec/roda/it8518/acpi/ec.asl
@@ -6,7 +6,7 @@ Device (EC0)
{
Name (_HID, EISAID ("PNP0C09")) // ACPI Embedded Controller
Name (_UID, 1)
- Name (_GPE, Add(EC_SCI_GPI, 16)) // GPE for Runtime SCI
+ Name (_GPE, EC_SCI_GPI)
Name (PWRS, 1)
Name (LIDS, 1)
diff --git a/src/mainboard/roda/rv11/acpi/ec.asl b/src/mainboard/roda/rv11/acpi/ec.asl
index e34393002d44..468a329237c6 100644
--- a/src/mainboard/roda/rv11/acpi/ec.asl
+++ b/src/mainboard/roda/rv11/acpi/ec.asl
@@ -1,4 +1,4 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#define EC_SCI_GPI 7
+#define EC_SCI_GPI (16 + 7)
#include <ec/roda/it8518/acpi/ec.asl>