summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@google.com>2023-03-09 17:54:14 -0700
committerPaul Fagerburg <pfagerburg@chromium.org>2023-03-15 17:30:19 +0000
commita18b8b44d746894d04fd3c2b84304d860840a472 (patch)
treed4155bf0c56753beb29ba5f60399ed4b57b9eadf
parent8d885612350b89daa1b11c34e77ae4544d6cf978 (diff)
downloadcoreboot-a18b8b44d746894d04fd3c2b84304d860840a472.tar.gz
coreboot-a18b8b44d746894d04fd3c2b84304d860840a472.tar.bz2
coreboot-a18b8b44d746894d04fd3c2b84304d860840a472.zip
mb/google/skyrim: Do not pass recovery APCB
If recovery APCB is not passed, amdfwtool will build amdfw*.rom with AMD_BIOS_APCB_BK entry pointing to the same offset as AMD_BIOS_APCB entry. This will help to save 40 KiB flash space in each FW slot. On ChromeOS, this means saving ~120 KiB flash space. BUG=b:240696002 TEST=Build and boot to OS in Skyrim. Change-Id: Ib3bbc1eededae20b2cd48f514722a207c46536a0 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/73662 Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/skyrim/Makefile.inc1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mainboard/google/skyrim/Makefile.inc b/src/mainboard/google/skyrim/Makefile.inc
index c1d1108fc3de..5a44d8b6c977 100644
--- a/src/mainboard/google/skyrim/Makefile.inc
+++ b/src/mainboard/google/skyrim/Makefile.inc
@@ -29,7 +29,6 @@ ifneq ($(wildcard $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memor
LIB_SPD_DEPS = $(SPD_SOURCES)
APCB_SOURCES = $(obj)/$(APCB_NAME).gen
-APCB_SOURCES_RECOVERY = $(obj)/$(APCB_NAME).gen
$(obj)/$(APCB_NAME).gen: $(SPD_SOURCES) \
$(APCB_V3_EDIT_TOOL) \