diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2021-01-21 13:59:28 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-01-25 08:53:10 +0000 |
| commit | a626d2ed6f15748f40500cef1ec074ed9fd785df (patch) | |
| tree | 4926d3a53bd46a0be0bb89397df9239f7688d5e9 | |
| parent | f38dc8b11dbfaca71c49719c43a62ba404394196 (diff) | |
| download | coreboot-a626d2ed6f15748f40500cef1ec074ed9fd785df.tar.gz coreboot-a626d2ed6f15748f40500cef1ec074ed9fd785df.tar.bz2 coreboot-a626d2ed6f15748f40500cef1ec074ed9fd785df.zip | |
soc/amd/common/acpi: Add _UID for PNP0C02 devices
When MAINBOARD_HAS_SPEAKER is false, the SPKR gets _HID PNP0C02. This
conflicts with the LDRC device. PNP0C02 is also used other places in the
picasso code base, so I chose a random _UID for each device. The _UIDs
are unique in the code base so it's easy to search for duplicates.
BUG=b:175146875
TEST=Boot trembyle to linux
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I01be41515e011293e90a6b42b8e34de8ec3ffc18
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49813
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/soc/amd/common/acpi/lpc.asl | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/amd/common/acpi/lpc.asl b/src/soc/amd/common/acpi/lpc.asl index d2224e8f1342..254fc69793d1 100644 --- a/src/soc/amd/common/acpi/lpc.asl +++ b/src/soc/amd/common/acpi/lpc.asl @@ -22,6 +22,7 @@ Device(LPCB) { Device(LDRC) // LPC device: Resource consumption { Name (_HID, EISAID("PNP0C02")) // ID for Motherboard resources + Name (_UID, 0x3278) Name (CRS, ResourceTemplate () // Current Motherboard resources { Memory32Fixed(ReadWrite, // Setup for fixed resource location for SPI base address @@ -68,6 +69,7 @@ Device(LPCB) { Device(SPKR) { /* Speaker */ Name(_HID,EISAID(IO61_HID)) + Name (_UID, 0x7239) Name(_CRS, ResourceTemplate() { IO(Decode16, 0x0061, 0x0061, 0, 1) }) |