diff options
| author | Liju-Clr Chen <liju-clr.chen@mediatek.com> | 2022-09-19 16:17:54 +0800 |
|---|---|---|
| committer | Yu-Ping Wu <yupingso@google.com> | 2022-09-22 08:04:48 +0000 |
| commit | a8172c329fe309f3b5b409c1a59a227186400dd4 (patch) | |
| tree | e838c8919d19e1354e7a9a23110899b965984422 | |
| parent | 93e8f8043417a6adfe909255fc2148563be7cf0d (diff) | |
| download | coreboot-a8172c329fe309f3b5b409c1a59a227186400dd4.tar.gz coreboot-a8172c329fe309f3b5b409c1a59a227186400dd4.tar.bz2 coreboot-a8172c329fe309f3b5b409c1a59a227186400dd4.zip | |
soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM registers
This patch fixes AP hanging issue caused by the handshaking between
MCUPM and CPUfreq driver.
CPUfreq hardware failed to read MCUPM registers due to DEVAPC
permission. Therefore, update the DEVAPC settings to fix this issue.
BUG=none
TEST=CPUfreq in kernel test pass.
Change-Id: I6b30b01fc0be052182599709cbcc9139e6d09742
Signed-off-by: Liju-Clr Chen <liju-clr.chen@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67724
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/mediatek/mt8188/devapc.c | 6 | ||||
| -rw-r--r-- | src/soc/mediatek/mt8188/include/soc/devapc.h | 4 |
2 files changed, 10 insertions, 0 deletions
diff --git a/src/soc/mediatek/mt8188/devapc.c b/src/soc/mediatek/mt8188/devapc.c index 1fe3cf862656..260b9ffd9bf3 100644 --- a/src/soc/mediatek/mt8188/devapc.c +++ b/src/soc/mediatek/mt8188/devapc.c @@ -1550,6 +1550,12 @@ static void dump_peri_par_ao_apc(uintptr_t base) static void infra_init(uintptr_t base) { + /* Side band */ + SET32_BITFIELDS(getreg(base, MAS_SEC_0), MCUPM_SEC, SECURE_TRANS); + + /* Master domain */ + SET32_BITFIELDS(getreg(base, MAS_DOM_0), SCP_SSPM_DOM, DOMAIN_2, MCUPM_DOM, DOMAIN_2); + /* Default APC setting */ set_infra_ao_apc(base); } diff --git a/src/soc/mediatek/mt8188/include/soc/devapc.h b/src/soc/mediatek/mt8188/include/soc/devapc.h index e0b0f00ccf50..d742c220aed9 100644 --- a/src/soc/mediatek/mt8188/include/soc/devapc.h +++ b/src/soc/mediatek/mt8188/include/soc/devapc.h @@ -17,6 +17,10 @@ enum devapc_ao_offset { AO_APC_CON = 0x00F00, }; +DEFINE_BIT(MCUPM_SEC, 1) +DEFINE_BITFIELD(MCUPM_DOM, 11, 8) +DEFINE_BITFIELD(SCP_SSPM_DOM, 19, 16) + /****************************************************************************** * STRUCTURE DEFINITION ******************************************************************************/ |