summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2022-09-26 16:26:30 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-09-27 16:19:09 +0000
commitc6df44b95957014f50be59f622ad6baf20a97a28 (patch)
tree0a96a594d1e15cf347f6be120149aaf5e3a8d653
parentacc91c335b6d0e0b9162966368bdc92a59522064 (diff)
downloadcoreboot-c6df44b95957014f50be59f622ad6baf20a97a28.tar.gz
coreboot-c6df44b95957014f50be59f622ad6baf20a97a28.tar.bz2
coreboot-c6df44b95957014f50be59f622ad6baf20a97a28.zip
ec/lenovo/h8: Add Kconfig option for Fn-Ctrl swap
Having to use a runtime configurable option backend like CMOS just to specify the value of the "fn_ctrl_swap" option is annoying. Introduce a new Kconfig option to allow specifying the fallback value, which is only used when the option backend cannot provide a value. Change-Id: I00bb3cd60c443fc0c8adb82e8e0c436dfc5de24b Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67836 Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
-rw-r--r--src/ec/lenovo/h8/Kconfig8
-rw-r--r--src/ec/lenovo/h8/h8.c2
2 files changed, 9 insertions, 1 deletions
diff --git a/src/ec/lenovo/h8/Kconfig b/src/ec/lenovo/h8/Kconfig
index 698816f4e7d0..57d7da6c69fa 100644
--- a/src/ec/lenovo/h8/Kconfig
+++ b/src/ec/lenovo/h8/Kconfig
@@ -28,6 +28,14 @@ config H8_SUPPORT_BT_ON_WIFI
Disable BDC detection and assume bluetooth is installed. Required for
bluetooth on wifi cards, as it's not possible to detect it in coreboot.
+config H8_FN_CTRL_SWAP
+ bool "Swap Fn and Ctrl keys"
+ help
+ Specifies the fallback value of the "fn_ctrl_swap" option, which is
+ only used when the value cannot be obtained from the option backend.
+ The main use-case for this Kconfig option is to enable Fn-Ctrl swap
+ without using any runtime configurable option backends (e.g. CMOS).
+
config H8_HAS_BAT_THRESHOLDS_IMPL
bool
default n
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index bbe6490f0c47..3df20c14f3b9 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -311,7 +311,7 @@ static void h8_enable(struct device *dev)
if (conf->has_uwb)
h8_uwb_enable(get_uint_option("uwb", 1));
- h8_fn_ctrl_swap(get_uint_option("fn_ctrl_swap", 0));
+ h8_fn_ctrl_swap(get_uint_option("fn_ctrl_swap", CONFIG(H8_FN_CTRL_SWAP)));
h8_sticky_fn(get_uint_option("sticky_fn", 0));