summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorReka Norman <rekanorman@google.com>2021-12-09 12:09:27 +1100
committerFelix Held <felix-coreboot@felixheld.de>2021-12-23 14:33:28 +0000
commitd448f8ce0fe9955e7792f54cc278897152d53590 (patch)
tree90c3700fd8945569c7936a3f0649e6907997fae3
parent9fe2ce802af0751b2df657e487631df8fb60ab9f (diff)
downloadcoreboot-d448f8ce0fe9955e7792f54cc278897152d53590.tar.gz
coreboot-d448f8ce0fe9955e7792f54cc278897152d53590.tar.bz2
coreboot-d448f8ce0fe9955e7792f54cc278897152d53590.zip
drivers/intel/pmc_mux/conn: Change usb{23}_port_number fields to device pointers
Currently, the pmc_mux/conn driver uses integer fields to store the USB-2 and USB-3 port numbers from the SoC's point of view. Specifying these as integers in the devicetree is error-prone, and this information can instead be represented using pointers to the USB-2 and USB-3 devices. The port numbers can then be obtained from the paths of the linked devices, i.e. dev->path.usb.port_id. Modify the driver to store device pointers instead of integer port numbers, and update all devicetrees using the driver. These are the mainboards affected (all are Intel TGL or ADL based): google/brya google/volteer intel/adlrvp intel/shadowmountain intel/tglrvp system76/darp7 system76/galp5 system76/lemp10 Command used to update the devicetrees: git grep -l "usb._port_number" src/mainboard/ | \ xargs sed -i \ -e 's/register "usb2_port_number" = "\(.*\)"/use usb2_port\1 as usb2_port/g' \ -e 's/register "usb3_port_number" = "\(.*\)"/use tcss_usb3_port\1 as usb3_port/g' BUG=b:208502191 TEST=Build test all affected boards. On brya0, boot device and check that the ACPI tables generated with and without the change are the same. Change-Id: I5045b8ea57e8ca6f9ebd7d68a19486736b7e2809 Signed-off-by: Reka Norman <rekanorman@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60143 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Tim Crawford <tcrawford@system76.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
-rw-r--r--src/drivers/intel/pmc_mux/conn/chip.h8
-rw-r--r--src/drivers/intel/pmc_mux/conn/conn.c17
-rw-r--r--src/mainboard/google/brya/variants/anahera/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/anahera4es/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/brask/overridetree.cb12
-rw-r--r--src/mainboard/google/brya/variants/brya0/overridetree.cb12
-rw-r--r--src/mainboard/google/brya/variants/brya4es/overridetree.cb12
-rw-r--r--src/mainboard/google/brya/variants/felwinter/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/gimble/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/gimble4es/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/kano/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/primus/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/primus4es/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/redrix/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/redrix4es/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/taeko/overridetree.cb8
-rw-r--r--src/mainboard/google/brya/variants/taeko4es/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/chronicler/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/collis/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/copano/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/delbin/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/drobit/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/eldrid/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/elemi/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/lindar/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/terrador/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/todor/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/voema/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/volet/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/volteer/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/volteer2/overridetree.cb8
-rw-r--r--src/mainboard/google/volteer/variants/voxel/overridetree.cb8
-rw-r--r--src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb8
-rw-r--r--src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb12
-rw-r--r--src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb8
-rw-r--r--src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb8
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb8
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb8
-rw-r--r--src/mainboard/system76/darp7/devicetree.cb4
-rw-r--r--src/mainboard/system76/galp5/devicetree.cb4
-rw-r--r--src/mainboard/system76/lemp10/devicetree.cb4
41 files changed, 173 insertions, 168 deletions
diff --git a/src/drivers/intel/pmc_mux/conn/chip.h b/src/drivers/intel/pmc_mux/conn/chip.h
index 96347ae4a027..08a08e184d69 100644
--- a/src/drivers/intel/pmc_mux/conn/chip.h
+++ b/src/drivers/intel/pmc_mux/conn/chip.h
@@ -6,10 +6,10 @@
#include <boot/coreboot_tables.h>
struct drivers_intel_pmc_mux_conn_config {
- /* 1-based port numbers (from SoC point of view) */
- int usb2_port_number;
- /* 1-based port numbers (from SoC point of view) */
- int usb3_port_number;
+ /* A pointer to the SoC's USB-2 device */
+ DEVTREE_CONST struct device *usb2_port;
+ /* A pointer to the SoC's USB-3 device */
+ DEVTREE_CONST struct device *usb3_port;
/* Orientation of the sideband signals (SBU) */
enum type_c_orientation sbu_orientation;
/* Orientation of the High Speed lines */
diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c
index caff166392db..f238397245b4 100644
--- a/src/drivers/intel/pmc_mux/conn/conn.c
+++ b/src/drivers/intel/pmc_mux/conn/conn.c
@@ -16,6 +16,11 @@ static void conn_init(struct device *dev)
total_conn_count++;
}
+static unsigned int get_usb_port_number(const struct device *usb_port)
+{
+ return usb_port->path.usb.port_id + 1;
+}
+
static struct type_c_info *conn_get_cbmem_buffer(void)
{
struct type_c_info *info;
@@ -57,8 +62,8 @@ static void conn_write_cbmem_entry(struct device *dev)
count = info->port_count;
port_info = &info->port_info[count];
- port_info->usb2_port_number = config->usb2_port_number;
- port_info->usb3_port_number = config->usb3_port_number;
+ port_info->usb2_port_number = get_usb_port_number(config->usb2_port);
+ port_info->usb3_port_number = get_usb_port_number(config->usb3_port);
port_info->sbu_orientation = config->sbu_orientation;
port_info->data_orientation = config->hsl_orientation;
@@ -109,8 +114,8 @@ static void conn_fill_ssdt(const struct device *dev)
/* _DSD, Device-Specific Data */
dsd = acpi_dp_new_table("_DSD");
- acpi_dp_add_integer(dsd, "usb2-port-number", config->usb2_port_number);
- acpi_dp_add_integer(dsd, "usb3-port-number", config->usb3_port_number);
+ acpi_dp_add_integer(dsd, "usb2-port-number", get_usb_port_number(config->usb2_port));
+ acpi_dp_add_integer(dsd, "usb3-port-number", get_usb_port_number(config->usb3_port));
/*
* The kernel assumes that these Type-C signals (SBUs and HSLs) follow the CC lines,
@@ -161,8 +166,8 @@ bool intel_pmc_mux_conn_get_ports(const struct device *conn, unsigned int *usb2_
return false;
mux_config = conn->chip_info;
- *usb2_port = mux_config->usb2_port_number;
- *usb3_port = mux_config->usb3_port_number;
+ *usb2_port = get_usb_port_number(mux_config->usb2_port);
+ *usb3_port = get_usb_port_number(mux_config->usb3_port);
return true;
};
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb
index 118ce0c41f15..97be625f1cd9 100644
--- a/src/mainboard/google/brya/variants/anahera/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb
@@ -282,13 +282,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
index 118ce0c41f15..97be625f1cd9 100644
--- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
@@ -282,13 +282,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/brask/overridetree.cb b/src/mainboard/google/brya/variants/brask/overridetree.cb
index d1931cf361a4..fbb64ffd7b82 100644
--- a/src/mainboard/google/brya/variants/brask/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brask/overridetree.cb
@@ -188,18 +188,18 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
device generic 1 alias conn1 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 2 alias conn2 on end
end
end
diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb
index 3822a2c19e1a..cae22572b6a6 100644
--- a/src/mainboard/google/brya/variants/brya0/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb
@@ -626,18 +626,18 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
device generic 1 alias conn1 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 2 alias conn2 on end
end
end
diff --git a/src/mainboard/google/brya/variants/brya4es/overridetree.cb b/src/mainboard/google/brya/variants/brya4es/overridetree.cb
index 3822a2c19e1a..cae22572b6a6 100644
--- a/src/mainboard/google/brya/variants/brya4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brya4es/overridetree.cb
@@ -626,18 +626,18 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
device generic 1 alias conn1 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 2 alias conn2 on end
end
end
diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
index f9301fe21f24..a0643c592368 100644
--- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb
+++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
@@ -309,13 +309,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 2 alias conn2 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb
index 3d8f52bfda13..e804635359fa 100644
--- a/src/mainboard/google/brya/variants/gimble/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb
@@ -254,13 +254,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "3"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
index d0d54d7e2469..5f8bd0eabcd9 100644
--- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
@@ -217,13 +217,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "3"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb
index a4a5c54c341b..a7e42715567f 100644
--- a/src/mainboard/google/brya/variants/kano/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kano/overridetree.cb
@@ -487,13 +487,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb
index 0ddf2b13235c..7ef832cc5dc1 100644
--- a/src/mainboard/google/brya/variants/primus/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus/overridetree.cb
@@ -310,13 +310,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/primus4es/overridetree.cb b/src/mainboard/google/brya/variants/primus4es/overridetree.cb
index fffc1d0d911c..75610b87b2c6 100644
--- a/src/mainboard/google/brya/variants/primus4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus4es/overridetree.cb
@@ -304,13 +304,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index 5aa84bdcd335..977307696023 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -436,13 +436,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
index 9ffc6a0079ad..a31d025897fb 100644
--- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
@@ -440,13 +440,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb
index 985745f8dd38..b82e9de497fe 100644
--- a/src/mainboard/google/brya/variants/taeko/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb
@@ -421,13 +421,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 2 alias conn1 on end
end
end
diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
index dbca8eeb37a2..5ad69acfe427 100644
--- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
@@ -421,13 +421,13 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
device generic 2 alias conn1 on end
end
end
diff --git a/src/mainboard/google/volteer/variants/chronicler/overridetree.cb b/src/mainboard/google/volteer/variants/chronicler/overridetree.cb
index 4b9f0952a962..93ed52ba928e 100644
--- a/src/mainboard/google/volteer/variants/chronicler/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/chronicler/overridetree.cb
@@ -264,14 +264,14 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/collis/overridetree.cb b/src/mainboard/google/volteer/variants/collis/overridetree.cb
index 2fe500112560..3323bdf519f4 100644
--- a/src/mainboard/google/volteer/variants/collis/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/collis/overridetree.cb
@@ -205,15 +205,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "5"
- register "usb3_port_number" = "1"
+ use usb2_port5 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "2"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/copano/overridetree.cb b/src/mainboard/google/volteer/variants/copano/overridetree.cb
index 6ea6fd589685..7ffa7ab3c41c 100644
--- a/src/mainboard/google/volteer/variants/copano/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/copano/overridetree.cb
@@ -230,15 +230,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "5"
- register "usb3_port_number" = "1"
+ use usb2_port5 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "2"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
index a36ad1af9dab..378d4e2ee49a 100644
--- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -211,15 +211,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/drobit/overridetree.cb b/src/mainboard/google/volteer/variants/drobit/overridetree.cb
index 14a5ecf312d3..a31017e83dc0 100644
--- a/src/mainboard/google/volteer/variants/drobit/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/drobit/overridetree.cb
@@ -209,15 +209,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index f357f0da6f26..93544182e008 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -211,14 +211,14 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/elemi/overridetree.cb b/src/mainboard/google/volteer/variants/elemi/overridetree.cb
index 9ce349b277cd..22230ab25df2 100644
--- a/src/mainboard/google/volteer/variants/elemi/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/elemi/overridetree.cb
@@ -281,14 +281,14 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index 9dfd56cf40d3..2eb482d86cde 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -289,14 +289,14 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follows CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
index 53b0c42bea91..6d298184690a 100644
--- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
@@ -158,15 +158,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "5"
- register "usb3_port_number" = "1"
+ use usb2_port5 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "2"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb
index ece746bc8133..eb6105325896 100644
--- a/src/mainboard/google/volteer/variants/todor/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb
@@ -147,15 +147,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "5"
- register "usb3_port_number" = "1"
+ use usb2_port5 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "2"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb
index 082dfdf16077..8fdc0674db8b 100644
--- a/src/mainboard/google/volteer/variants/voema/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb
@@ -115,13 +115,13 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "5"
- register "usb3_port_number" = "1"
+ use usb2_port5 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "2"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/volet/overridetree.cb b/src/mainboard/google/volteer/variants/volet/overridetree.cb
index 1d1106373226..f4e22555d3f6 100644
--- a/src/mainboard/google/volteer/variants/volet/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volet/overridetree.cb
@@ -152,13 +152,13 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index f3b7549e8274..9375af3e9480 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -221,14 +221,14 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
index 7fe38a93d452..d024835aa03e 100644
--- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
@@ -288,14 +288,14 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
device generic 1 alias conn1 on end
end
end
diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb
index 2efc3ed556c6..4bca10358416 100644
--- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb
@@ -244,15 +244,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "9"
- register "usb3_port_number" = "1"
+ use usb2_port9 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb
index 133a737f661e..a3860c6f76c3 100644
--- a/src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb
+++ b/src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb
@@ -14,15 +14,15 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb
index e78d00fa7ff2..de5471cf65cf 100644
--- a/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb
+++ b/src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb
@@ -34,22 +34,22 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "3"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port3 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 2 alias conn2 on end
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb
index a23db8c0f989..91073f766115 100644
--- a/src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb
+++ b/src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb
@@ -14,15 +14,15 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "1"
- register "usb3_port_number" = "1"
+ use usb2_port1 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "2"
- register "usb3_port_number" = "2"
+ use usb2_port2 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
index 6cf83d2707ab..575739241e06 100644
--- a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
@@ -279,15 +279,15 @@ chip soc/intel/alderlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "6"
- register "usb3_port_number" = "1"
+ use usb2_port6 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "4"
- register "usb3_port_number" = "2"
+ use usb2_port4 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index 47c4368a5252..201983cc873b 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -319,15 +319,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "6"
- register "usb3_port_number" = "3"
+ use usb2_port6 as usb2_port
+ use tcss_usb3_port3 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "7"
- register "usb3_port_number" = "4"
+ use usb2_port7 as usb2_port
+ use tcss_usb3_port4 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index cd5493bc302d..d76c0f530c4b 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -323,15 +323,15 @@ chip soc/intel/tigerlake
chip drivers/intel/pmc_mux
device generic 0 on
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "6"
- register "usb3_port_number" = "3"
+ use usb2_port6 as usb2_port
+ use tcss_usb3_port3 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn
- register "usb2_port_number" = "5"
- register "usb3_port_number" = "2"
+ use usb2_port5 as usb2_port
+ use tcss_usb3_port2 as usb3_port
# SBU is fixed, HSL follows CC
register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
device generic 1 alias conn1 on end
diff --git a/src/mainboard/system76/darp7/devicetree.cb b/src/mainboard/system76/darp7/devicetree.cb
index dc369adc8e5a..75b0836050c2 100644
--- a/src/mainboard/system76/darp7/devicetree.cb
+++ b/src/mainboard/system76/darp7/devicetree.cb
@@ -316,8 +316,8 @@ chip soc/intel/tigerlake
device generic 0 on
chip drivers/intel/pmc_mux/conn
# J_TYPEC2
- register "usb2_port_number" = "6"
- register "usb3_port_number" = "1"
+ use usb2_port6 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
diff --git a/src/mainboard/system76/galp5/devicetree.cb b/src/mainboard/system76/galp5/devicetree.cb
index 3764d07658e3..880da1eee8d4 100644
--- a/src/mainboard/system76/galp5/devicetree.cb
+++ b/src/mainboard/system76/galp5/devicetree.cb
@@ -320,8 +320,8 @@ chip soc/intel/tigerlake
device generic 0 on
chip drivers/intel/pmc_mux/conn
# J_TYPEC2
- register "usb2_port_number" = "6"
- register "usb3_port_number" = "1"
+ use usb2_port6 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end
diff --git a/src/mainboard/system76/lemp10/devicetree.cb b/src/mainboard/system76/lemp10/devicetree.cb
index 21928ec089e1..96ee0a1b9c36 100644
--- a/src/mainboard/system76/lemp10/devicetree.cb
+++ b/src/mainboard/system76/lemp10/devicetree.cb
@@ -281,8 +281,8 @@ chip soc/intel/tigerlake
device generic 0 on
chip drivers/intel/pmc_mux/conn
# J_TYPEC1
- register "usb2_port_number" = "3"
- register "usb3_port_number" = "1"
+ use usb2_port3 as usb2_port
+ use tcss_usb3_port1 as usb3_port
# SBU & HSL follow CC
device generic 0 alias conn0 on end
end