summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-11-04 19:12:21 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-11-04 18:47:04 +0000
commite141f358eb1b4386c041ed433e8977c4cdf409c1 (patch)
treef1fb9d216a8a59fcd86c93ba72812cb4f6a57b4e
parentc8f25e0c0551821554b96c449b6323de8a14a030 (diff)
downloadcoreboot-e141f358eb1b4386c041ed433e8977c4cdf409c1.tar.gz
coreboot-e141f358eb1b4386c041ed433e8977c4cdf409c1.tar.bz2
coreboot-e141f358eb1b4386c041ed433e8977c4cdf409c1.zip
Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function"
This reverts commit 3bc9fbb496c7e1ae346c8d7e98d2bcabbbbe8673. The patch that added hob_enhancedwarningloglib.h was marked as private after the Jenkins run, so I didn't see and submit it before submitting the patch that gets reverted by this commit. Temporary revert this patch to fix the coreboot tree until the issue with the missing patch is sorted out. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69229 Reviewed-by: Tim Crawford <tcrawford@system76.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Jonathan Zhang <jonzhang@fb.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-by: Jason Glenesk <jason.glenesk@amd.corp-partner.google.com> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Reviewed-by: Patrick Georgi <patrick@coreboot.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/xeon_sp/cpx/Makefile.inc2
-rw-r--r--src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h2
-rw-r--r--src/soc/intel/xeon_sp/cpx/soc_util.c14
3 files changed, 1 insertions, 17 deletions
diff --git a/src/soc/intel/xeon_sp/cpx/Makefile.inc b/src/soc/intel/xeon_sp/cpx/Makefile.inc
index 7e18b923c047..0cd267b71259 100644
--- a/src/soc/intel/xeon_sp/cpx/Makefile.inc
+++ b/src/soc/intel/xeon_sp/cpx/Makefile.inc
@@ -5,7 +5,7 @@ ifeq ($(CONFIG_SOC_INTEL_COOPERLAKE_SP),y)
subdirs-y += ../../../../cpu/intel/turbo
subdirs-y += ../../../../cpu/intel/microcode
-romstage-y += romstage.c ddr.c soc_util.c
+romstage-y += romstage.c ddr.c
romstage-$(CONFIG_DISPLAY_UPD_DATA) += upd_display.c
romstage-$(CONFIG_DISPLAY_HOBS) += hob_display.c
diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h b/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
index c4e2a7d49e5e..5ce392863c0d 100644
--- a/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
+++ b/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
@@ -5,13 +5,11 @@
#include <hob_iiouds.h>
#include <hob_memmap.h>
-#include <hob_enhancedwarningloglib.h>
const struct SystemMemoryMapHob *get_system_memory_map(void);
uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack);
int soc_get_stack_for_port(int port);
-const EWL_PRIVATE_DATA *get_ewl_hob(void);
#endif /* _SOC_UTIL_H_ */
diff --git a/src/soc/intel/xeon_sp/cpx/soc_util.c b/src/soc/intel/xeon_sp/cpx/soc_util.c
index 2a8b6c94ece1..cd1e06d29093 100644
--- a/src/soc/intel/xeon_sp/cpx/soc_util.c
+++ b/src/soc/intel/xeon_sp/cpx/soc_util.c
@@ -9,20 +9,6 @@
#include <soc/soc_util.h>
#include <soc/util.h>
-const EWL_PRIVATE_DATA *get_ewl_hob(void)
-{
- size_t hob_size;
- static const EWL_PRIVATE_DATA *hob;
- const uint8_t ewl_id_hob_guid[16] = FSP_HOB_EWLID_GUID;
-
- if (hob != NULL)
- return hob;
-
- hob = fsp_find_extension_hob_by_guid(ewl_id_hob_guid, &hob_size);
- assert(hob != NULL && hob_size != 0);
- return hob;
-}
-
const struct SystemMemoryMapHob *get_system_memory_map(void)
{
size_t hob_size;