summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2024-02-22 14:53:21 +0100
committerFelix Held <felix-coreboot@felixheld.de>2024-02-23 16:44:46 +0000
commite1fc17f3c347c4b3a5d92b30192e064d5992d79f (patch)
tree1fbdec540ab1415e4aff31ce85a9a11556be8125
parent4e3d2a16ff532cbb8dfe4ea5eda56a7c23e65f67 (diff)
downloadcoreboot-e1fc17f3c347c4b3a5d92b30192e064d5992d79f.tar.gz
coreboot-e1fc17f3c347c4b3a5d92b30192e064d5992d79f.tar.bz2
coreboot-e1fc17f3c347c4b3a5d92b30192e064d5992d79f.zip
soc/amd/common/acp: use clrsetbits32p to avoid need for casts
Use clrsetbits32p instead of clrsetbits32 to not need to cast the uintptr_t address to void * in the function call. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Ic29bf04866a7e1d5c831422f31803a724a41069b Reviewed-on: https://review.coreboot.org/c/coreboot/+/80700 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
-rw-r--r--src/soc/amd/common/block/acp/acp_gen1.c2
-rw-r--r--src/soc/amd/common/block/acp/acp_gen2.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/common/block/acp/acp_gen1.c b/src/soc/amd/common/block/acp/acp_gen1.c
index 0fe37f380674..4bfd71110e56 100644
--- a/src/soc/amd/common/block/acp/acp_gen1.c
+++ b/src/soc/amd/common/block/acp/acp_gen1.c
@@ -17,7 +17,7 @@
static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set)
{
- clrsetbits32((void *)(bar + reg), clear, set);
+ clrsetbits32p(bar + reg, clear, set);
}
void acp_init(struct device *dev)
diff --git a/src/soc/amd/common/block/acp/acp_gen2.c b/src/soc/amd/common/block/acp/acp_gen2.c
index 50de4b0bd972..be24ec91e9f6 100644
--- a/src/soc/amd/common/block/acp/acp_gen2.c
+++ b/src/soc/amd/common/block/acp/acp_gen2.c
@@ -17,7 +17,7 @@
static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set)
{
- clrsetbits32((void *)(bar + reg), clear, set);
+ clrsetbits32p(bar + reg, clear, set);
}
void acp_init(struct device *dev)