diff options
| author | Subrata Banik <subratabanik@google.com> | 2022-05-31 23:28:57 +0530 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-06-07 12:51:00 +0000 |
| commit | e43adb67bc699faa3e2e895da3260e526eb21c7b (patch) | |
| tree | 947dbe07d30af477a4fd929e66c641eb7650e1f4 | |
| parent | 801dbf4f09db70801ece813dad7fec3129759ef1 (diff) | |
| download | coreboot-e43adb67bc699faa3e2e895da3260e526eb21c7b.tar.gz coreboot-e43adb67bc699faa3e2e895da3260e526eb21c7b.tar.bz2 coreboot-e43adb67bc699faa3e2e895da3260e526eb21c7b.zip | |
soc/intel/cmn/block/cpu: Set BIOS_DONE on all CPUs
As per Intel Processor EDS, BIOS_DONE bit needs to be set on
all CPUs via MSR.
Also, implement a function to perform any SoC recommended CPU
programming prior to post CPUs init. At present calling
`cpu_soc_bios_done()` for all CPUs from `before_post_cpus_init()`.
Note: It is expected that `before_post_cpus_init()` will be
extended with other CPU programming recommendations in follow up
patches, for example: reload microcode patch etc.
BUG=b:233199592
TEST=Build and boot google/taeko to ChromeOS.
Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I8066cd724c9f15d259aeb23f3aa71a2d224d5340
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64834
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
| -rw-r--r-- | src/soc/intel/common/block/cpu/mp_init.c | 11 | ||||
| -rw-r--r-- | src/soc/intel/common/block/include/intelblocks/mp_init.h | 7 |
2 files changed, 18 insertions, 0 deletions
diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c index 9b4278fa1bac..cec767a9a0a3 100644 --- a/src/soc/intel/common/block/cpu/mp_init.c +++ b/src/soc/intel/common/block/cpu/mp_init.c @@ -167,6 +167,17 @@ static void wrapper_x86_setup_mtrrs(void *unused) x86_setup_mtrrs_with_detect(); } +static void wrapper_set_bios_done(void *unused) +{ + cpu_soc_bios_done(); +} + +void before_post_cpus_init(void) +{ + if (mp_run_on_all_cpus(&wrapper_set_bios_done, NULL) != CB_SUCCESS) + printk(BIOS_ERR, "Set BIOS Done failure\n"); +} + /* Ensure to re-program all MTRRs based on DRAM resource settings */ static void post_cpus_init(void *unused) { diff --git a/src/soc/intel/common/block/include/intelblocks/mp_init.h b/src/soc/intel/common/block/include/intelblocks/mp_init.h index 8a413eae8ce4..9029c91c4546 100644 --- a/src/soc/intel/common/block/include/intelblocks/mp_init.h +++ b/src/soc/intel/common/block/include/intelblocks/mp_init.h @@ -34,6 +34,13 @@ void get_microcode_info(const void **microcode, int *parallel); void init_cpus(void); /* + * This function will perform any recommended CPU (BSP and AP) initialization + * after coreboot has done the multiprocessor initialization (before FSP-S) + * and prior to coreboot perform post_cpus_init (after DRAM resources are set). + */ +void before_post_cpus_init(void); + +/* * SoC Overrides * * All new SoC must implement below functionality for ramstage. |